Skip to content

Commit

Permalink
inheritance
Browse files Browse the repository at this point in the history
  • Loading branch information
PankajBhojwani committed Dec 1, 2020
1 parent 7ddb322 commit 5cf8216
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions doc/specs/Configuration object for profiles.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ settings json file, each state-appearance will be stored in an object of this cl
piped over to the `AppAppearanceConfig` objects in `TerminalApp`. This is the way we already pipe over information
such as `FontFace` and `CursorStyle` from the settings model to the app.

#### Need to talk about inheritance here

### Allowed parameters

For now, these states are meant to be entirely appearance-based. So, not all parameters which can be
Expand All @@ -45,6 +43,18 @@ would cause a resize in this object.) Here are the list of parameters we will al
- `cursorShape`
- `backgroundImage`

We may wish to allow further parameters in these objects in the future (like `bellStyle`?). The addition
of further parameters can be discussed in the future and is out of scope for this spec.

### Inheritance

We have to decide how we want to deal with the case(s) where not all parameters are defined - i.e. what
values should we use for undefined parameters? The current proposal is as follows:

If the profile defines an `unfocusedState`, any parameters not explicitly defined within it will adopt
the values from the profile itself. If the profile does not define an `unfocusedState`, then the global/default `unfocusedState` is used
for this profile.

## UI/UX Design

Users will be able to add a new setting to their profiles that will look like this:
Expand Down

1 comment on commit 5cf8216

@github-actions

This comment was marked as outdated.

Please sign in to comment.