Skip to content

Commit

Permalink
format
Browse files Browse the repository at this point in the history
  • Loading branch information
miniksa committed Feb 23, 2022
1 parent 5a8b769 commit 7a987d6
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion src/cascadia/TerminalApp/TerminalPage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2789,7 +2789,7 @@ namespace winrt::TerminalApp::implementation
}

// Method Description:
// - Notifies all attached console controls that the visibility of the
// - Notifies all attached console controls that the visibility of the
// hosting window has changed. The underlying PTYs may need to know this
// for the proper response to `::GetConsoleWindow()` from a Win32 console app.
// Arguments:
Expand Down
18 changes: 9 additions & 9 deletions src/interactivity/base/InteractivityFactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ using namespace Microsoft::Console::Interactivity;
// Method Description:
// - Gives the pseudo console window a target to relay show/hide window messages
// Arguments:
// - func - A function that will take a true for "show" and false for "hide" and
// - func - A function that will take a true for "show" and false for "hide" and
// relay that information to the attached terminal to adjust its window state.
// Return Value:
// - <none>
Expand Down Expand Up @@ -453,7 +453,7 @@ void InteractivityFactory::SetPseudoWindowCallback(std::function<void(bool)> fun
// during prototyping and didn't give quite the results needed to determine show/hide window
// state. The notes are left here for future expeditions into message queues.
// case WM_QUERYOPEN:
// It can be fun to toggle WM_QUERYOPEN but DefWindowProc returns TRUE.
// It can be fun to toggle WM_QUERYOPEN but DefWindowProc returns TRUE.
case WM_SIZE:
{
if (wParam == SIZE_RESTORED)
Expand All @@ -467,23 +467,23 @@ void InteractivityFactory::SetPseudoWindowCallback(std::function<void(bool)> fun
}
break;
}
// case WM_WINDOWPOSCHANGING:
// case WM_WINDOWPOSCHANGING:
// As long as user32 didn't eat the `ShowWindow` call because the window state requested
// matches the existing WS_VISIBLE state of the HWND... we should hear from it in WM_WINDOWPOSCHANGING.
// WM_WINDOWPOSCHANGING can tell us a bunch through the flags fields.
// We can also check IsIconic/IsZoomed on the HWND during the message
// and we could suppress the change to prevent things from happening.
// case WM_SYSCOMMAND:
// WM_SYSCOMMAND will not come through. Don't try.
// WM_SYSCOMMAND will not come through. Don't try.
case WM_SHOWWINDOW:
// WM_SHOWWINDOW comes through on some of the messages.
{
if (0 == lParam) // Someone explicitly called ShowWindow on us.
// WM_SHOWWINDOW comes through on some of the messages.
{
_WritePseudoWindowCallback((bool)wParam);
if (0 == lParam) // Someone explicitly called ShowWindow on us.
{
_WritePseudoWindowCallback((bool)wParam);
}
}
}
}
// If we get this far, call the default window proc
return DefWindowProcW(hWnd, Message, wParam, lParam);
}
Expand Down
2 changes: 1 addition & 1 deletion src/interactivity/base/ServiceLocator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ Globals& ServiceLocator::LocateGlobals()

// Method Description:
// - Installs a callback method to receive notifications when the pseudo console
// window is shown or hidden by an attached client application (so we can
// window is shown or hidden by an attached client application (so we can
// translate it and forward it to the attached terminal, in case it would like
// to react accordingly.)
// Arguments:
Expand Down

1 comment on commit 7a987d6

@github-actions

This comment was marked as resolved.

Please sign in to comment.