Skip to content

Commit

Permalink
These notes about ISwapChainPanelNative2 are VERY IMPORTANT
Browse files Browse the repository at this point in the history
  • Loading branch information
zadjii-msft committed Jul 16, 2020
1 parent 8c5041b commit 7b8806b
Show file tree
Hide file tree
Showing 5 changed files with 66 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/tools/ScratchWinRTClient/pch.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,9 @@
#include <winrt/Windows.Foundation.h>
#include <winrt/Windows.Foundation.Collections.h>

#include <winrt/Windows.UI.Xaml.Controls.h>
#include <winrt/Windows.UI.Xaml.Media.h>
#include <windows.ui.xaml.media.dxinterop.h>

// Manually include til after we include Windows.Foundation to give it winrt superpowers
#include "til.h"
50 changes: 50 additions & 0 deletions src/tools/ScratchWinRTServer/HostClass.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,54 @@ namespace winrt::ScratchWinRTServer::implementation
_DoCount += 4;
return S_OK;
}

void HostClass::Attach(const Windows::UI::Xaml::Controls::SwapChainPanel& panel)
{
_panel = panel;
}

void HostClass::BeginRendering()
{
IDXGISwapChain1* swapChain; // = _getSwapchainFromMyRenderer();

// DANGER: I'm fairly certain that this needs to be called on the
// `SwapChainPanel`s UI thread. So we may be slightly out of luck here.
// Unless we can just
// co_await winrt::resume_foreground(_panel.Dispatcher());
// But that's a thread in another process!

auto nativePanel = _panel.as<ISwapChainPanelNative>();
nativePanel->SetSwapChain(swapChain);

// Holy crap look at:
// ISwapChainPanelNative2::SetSwapChainHandle method
// https://docs.microsoft.com/en-us/windows/win32/api/windows.ui.xaml.media.dxinterop/nf-windows-ui-xaml-media-dxinterop-iswapchainpanelnative2-setswapchainhandle
//
// SetSwapChain(HANDLE swapChainHandle) allows a swap chain to be
// rendered by referencing a shared handle to the swap chain. This
// enables scenarios where a swap chain is created in one process and
// needs to be passed to another process.
//
// XAML supports setting a DXGI swap chain as the content of a
// SwapChainPanel element. Apps accomplish this by querying for the
// ISwapChainPanelNative interface from a SwapChainPanel instance and
// calling SetSwapChain(IDXGISwapChain *swapChain).
//
// This process works for pointers to in process swap chains. However,
// this doesn’t work for VoIP apps, which use a two-process model to
// enable continuing calls on a background process when a foreground
// process is suspended or shut down. This two-process implementation
// requires the ability to pass a shared handle to a swap chain, rather
// than a pointer, created on the background process to the foreground
// process to be rendered in a XAML SwapChainPanel in the foreground
// app.

// I _believe_ this will work something like:
//
// HANDLE hSwapChain;
// auto nativePanel2 = _panel.as<ISwapChainPanelNative2>();
// nativePanel2->SetSwapChainHandle(hSwapChain);
//
// But I'm not sure yet.
}
}
5 changes: 5 additions & 0 deletions src/tools/ScratchWinRTServer/HostClass.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,14 @@ namespace winrt::ScratchWinRTServer::implementation

HRESULT __stdcall Call() override;

void Attach(const Windows::UI::Xaml::Controls::SwapChainPanel& panel);
void BeginRendering();

private:
int _DoCount{ 0 };
winrt::guid _id;

Windows::UI::Xaml::Controls::SwapChainPanel _panel{ nullptr };
};
}

Expand Down
3 changes: 3 additions & 0 deletions src/tools/ScratchWinRTServer/HostClass.idl
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ namespace ScratchWinRTServer
Int32 DoCount { get; };
Guid Id { get; };

void Attach(Windows.UI.Xaml.Controls.SwapChainPanel panel);
void BeginRendering();

// Adding a Windows.UI.Xaml element will crash the server when the
// server tries to instantiate the element without a XAML host.
//
Expand Down
4 changes: 4 additions & 0 deletions src/tools/ScratchWinRTServer/pch.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
#include <winrt/Windows.Foundation.h>
#include <winrt/Windows.Foundation.Collections.h>

#include <winrt/Windows.UI.Xaml.Controls.h>
#include <winrt/Windows.UI.Xaml.Media.h>
#include <windows.ui.xaml.media.dxinterop.h>

// Manually include til after we include Windows.Foundation to give it winrt superpowers
#include "til.h"

Expand Down

1 comment on commit 7b8806b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New misspellings found, please review:

  • DAA
  • dba
  • ddb
  • follwoing
  • IClosable
  • IMy
  • initally
  • IScratch
  • IStringable
  • iunk
  • mci
  • mciraw
  • MULTIPLEUSE
  • Ooof
  • recieve
  • REGCLS
  • Stringable
  • subfolder
  • Zhu
To accept these changes, run the following commands
perl -e '
my @expect_files=qw('".github/actions/spell-check/expect/alphabet.txt
.github/actions/spell-check/expect/expect.txt
.github/actions/spell-check/expect/web.txt"');
@ARGV=@expect_files;
my @stale=qw('"atg BKMK colo consoleaccessibility Dst FFF fullcolor hyperlink IDefault minmax NRCS phsl popclip PVOID remoting rerendered ROWSTOSCROLL SCS shobjidl stdarg stddef stdlib unfocuses Unk xab xb xbc xca xce xdd xffff "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect/7b8806b1fe73bb3190555d2f86a583bacb17aa26.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"DAA dba ddb dst follwoing IClosable IMy initally IScratch IStringable iunk mci mciraw MULTIPLEUSE nrcs Ooof pvoid recieve REGCLS Remoting Scs Shobjidl Stringable subfolder unk Zhu "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spell-check/expect || echo '... you want to ensure .github/actions/spell-check/expect/7b8806b1fe73bb3190555d2f86a583bacb17aa26.txt is added to your repository...'
✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

⚠️ The command is written for posix shells. You can copy the contents of each perl command excluding the outer ' marks and dropping any '"/"' quotation mark pairs into a file and then run perl file.pl from the root of the repository to run the code. Alternatively, you can manually insert the items...

If the listed items are:

  • ... misspelled, then please correct them instead of using the command.
  • ... names, please add them to .github/actions/spell-check/dictionary/names.txt.
  • ... APIs, you can add them to a file in .github/actions/spell-check/dictionary/.
  • ... just things you're using, please add them to an appropriate file in .github/actions/spell-check/expect/.
  • ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spell-check/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The :check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

⚠️ Reviewers

At present, the action that triggered this message will not show its ❌ in this PR unless the branch is within this repository.
Thus, you should make sure that this comment has been addressed before encouraging the merge bot to merge this PR.

Please sign in to comment.