Skip to content

Commit

Permalink
Change the SUB control glyph to U+2426 (#16559)
Browse files Browse the repository at this point in the history
Up to now we've using `U+2E2E` (reverse question mark) to represent the
`SUB` control glyph. This PR changes the glyph to `U+2426` (substitute
form two), which is also rendered as a reverse question mark, but is
more semantically correct.

The original `SUB` control rendering was implemented in PR #15075.

I've manually confirmed that `printf "\x1A"` is now shown as a reverse
question mark in OpenConsole when using the Cascadia Code font. That
would not previously have worked, because `U+2E2E` is not supported by
Cascadia Code.

Closes #16558
  • Loading branch information
j4james authored Jan 16, 2024
1 parent a4445ed commit 92f9ff9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/terminal/parser/OutputStateMachineEngine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ bool OutputStateMachineEngine::ActionExecute(const wchar_t wch)
case AsciiChars::SUB:
// The SUB control is used to cancel a control sequence in the same
// way as CAN, but unlike CAN it also displays an error character,
// typically a reverse question mark.
_dispatch->Print(L'\u2E2E');
// typically a reverse question mark (Unicode substitute form two).
_dispatch->Print(L'\u2426');
break;
case AsciiChars::DEL:
// The DEL control can sometimes be translated into a printable glyph
Expand Down

0 comments on commit 92f9ff9

Please sign in to comment.