Skip to content

Commit

Permalink
Well at least it seems like we don't have one output thread per contr…
Browse files Browse the repository at this point in the history
…ol now. That's something
  • Loading branch information
zadjii-msft committed Mar 15, 2023
1 parent d7637ff commit 9da196d
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions src/cascadia/TerminalControl/BlockContent.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ namespace winrt::Microsoft::Terminal::Control::implementation
// GH#8969: pre-seed working directory to prevent potential races
_terminal->SetWorkingDirectory(_settings->StartingDirectory());

_newPromptRevoker = _terminal->NewPrompt({ get_weak(), &BlockContent::_newPromptHandler });

// auto pfnCopyToClipboard = std::bind(&ControlCore::_terminalCopyToClipboard, this, std::placeholders::_1);
// _terminal->SetCopyToClipboardCallback(pfnCopyToClipboard);

Expand Down Expand Up @@ -293,8 +295,6 @@ namespace winrt::Microsoft::Terminal::Control::implementation

_terminal->CreateFromSettings(*_settings, *_renderer);

_newPromptRevoker = _terminal->NewPrompt({ get_weak(), &BlockContent::_newPromptHandler });

// IMPORTANT! Set this callback up sooner than later. If we do it
// after Enable, then it'll be possible to paint the frame once
// _before_ the warning handler is set up, and then warnings from
Expand All @@ -321,9 +321,12 @@ namespace winrt::Microsoft::Terminal::Control::implementation
_initializedTerminal = true;
} // scope for TerminalLock

// Start the connection outside of lock, because it could
// start writing output immediately.
_connection.Start();
if (_first == this->get_strong())
{
// Start the connection outside of lock, because it could
// start writing output immediately.
_connection.Start();
}

return true;
}
Expand Down

1 comment on commit 9da196d

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@check-spelling-bot Report

🔴 Please review

See the 📜action log for details.

Unrecognized words (3)

attemtpts
corewindow
curremt

Previously acknowledged words that are now absent CLA cpprest demoable DUMMYUNIONNAME everytime Hirots inthread ntsubauth NTWIN OPENIF OPENLINK PCLIENT PCOBJECT PCUNICODE PNTSTATUS pplx PPROCESS PUNICODE reingest unmark websockets xwwyzz xxyyzz :arrow_right:
To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the git@github.com:microsoft/terminal.git repository
on the dev/migrie/fhl/notebook-proto-000 branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/terminal/actions/runs/4437938774/attempts/1'
✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

⚠️ The command is written for posix shells. If it doesn't work for you, you can manually add (one word per line) / remove items to expect.txt and the excludes.txt files.

If the listed items are:

  • ... misspelled, then please correct them instead of using the command.
  • ... names, please add them to .github/actions/spelling/allow/names.txt.
  • ... APIs, you can add them to a file in .github/actions/spelling/allow/.
  • ... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
  • ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Please sign in to comment.