Skip to content

Commit

Permalink
This fixes C-M-space for WSL but not for Win32, but I'm not sure ther…
Browse files Browse the repository at this point in the history
…e's a problem in Win32 quite yet. (#5208)

## Summary of the Pull Request

When conpty is in VT input mode, we pass through all the input we receive. This includes all the other `Action*Dispatch` methods, but missed this one.

## References
* Missed during #4856 
* Discovered during the course of the #4192 review
* #5205 Also investigated part of the issue, but found a different bug.

## PR Checklist
* [x] Doesn't close anything, just related to above things.
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments
This will fix the <kbd>ctrl+alt+space</kbd> in the Terminal thing mentioned in #4192, but doesn't actually resolve the root cause of that bug (which is tracked in #5205).
  • Loading branch information
zadjii-msft authored Apr 1, 2020
1 parent 584e449 commit bdbf404
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/terminal/parser/InputStateMachineEngine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,11 @@ bool InputStateMachineEngine::_DoControlCharacter(const wchar_t wch, const bool
// - true iff we successfully dispatched the sequence.
bool InputStateMachineEngine::ActionExecuteFromEscape(const wchar_t wch)
{
if (_pDispatch->IsVtInputEnabled() && _pfnFlushToInputQueue)
{
return _pfnFlushToInputQueue();
}

return _DoControlCharacter(wch, true);
}

Expand Down

0 comments on commit bdbf404

Please sign in to comment.