Add unit tests

microsoft · Apr 19, 2021 · d8383e0 · d8383e0
1 parent cf2105c
commit d8383e0
Show file tree

Hide file tree

Showing 3 changed files with 247 additions and 3 deletions.
diff --git a/src/cascadia/LocalTests_TerminalApp/TabTests.cpp b/src/cascadia/LocalTests_TerminalApp/TabTests.cpp
@@ -629,6 +629,28 @@ namespace TerminalAppLocalTests
                     "brightPurple": "#FF00FF",
                     "brightCyan": "#00FFFF",
                     "brightWhite": "#FFFFFF"
+                },
+                {
+                    "name": "One Half Light",
+                    "foreground": "#383A42",
+                    "background": "#FAFAFA",
+                    "cursorColor": "#4F525D",
+                    "black": "#383A42",
+                    "red": "#E45649",
+                    "green": "#50A14F",
+                    "yellow": "#C18301",
+                    "blue": "#0184BC",
+                    "purple": "#A626A4",
+                    "cyan": "#0997B3",
+                    "white": "#FAFAFA",
+                    "brightBlack": "#4F525D",
+                    "brightRed": "#DF6C75",
+                    "brightGreen": "#98C379",
+                    "brightYellow": "#E4C07A",
+                    "brightBlue": "#61AFEF",
+                    "brightPurple": "#C577DD",
+                    "brightCyan": "#56B5C1",
+                    "brightWhite": "#FFFFFF"
                 }
             ]
         })" };
@@ -1087,19 +1109,237 @@ namespace TerminalAppLocalTests
     void TabTests::TestPreviewCommitScheme()
     {
         Log::Comment(L"Preview a color scheme. Make sure it's applied, then committed accordingly");
-        VERIFY_IS_TRUE(false, L"TODO: Implement test");
+
+        auto page = _commonSetup();
+        VERIFY_IS_NOT_NULL(page);
+
+        TestOnUIThread([&page]() {
+            const auto& activeControl{ page->_GetActiveControl() };
+            VERIFY_IS_NOT_NULL(activeControl);
+
+            const auto& controlSettings = activeControl.Settings().as<TerminalSettings>();
+            VERIFY_IS_NOT_NULL(controlSettings);
+
+            const auto& originalSettings = controlSettings.GetParent();
+            VERIFY_IS_NOT_NULL(originalSettings);
+
+            VERIFY_ARE_EQUAL(til::color{ 0xff0c0c0c }, controlSettings.DefaultBackground());
+        });
+
+        TestOnUIThread([&page]() {
+            Log::Comment(L"Emulate previewing the SetColorScheme action");
+            SetColorSchemeArgs args{ L"Vintage" };
+            page->_PreviewColorScheme(args);
+        });
+
+        TestOnUIThread([&page]() {
+            const auto& activeControl{ page->_GetActiveControl() };
+            VERIFY_IS_NOT_NULL(activeControl);
+
+            const auto& controlSettings = activeControl.Settings().as<TerminalSettings>();
+            VERIFY_IS_NOT_NULL(controlSettings);
+
+            const auto& previewSettings = controlSettings.GetParent();
+            VERIFY_IS_NOT_NULL(previewSettings);
+
+            const auto& originalSettings = previewSettings.GetParent();
+            VERIFY_IS_NOT_NULL(originalSettings);
+
+            Log::Comment(L"Color should be changed to the preview");
+            VERIFY_ARE_EQUAL(til::color{ 0xff000000 }, controlSettings.DefaultBackground());
+            VERIFY_ARE_EQUAL(originalSettings, page->_originalSettings);
+        });
+
+        TestOnUIThread([&page]() {
+            Log::Comment(L"Emulate commiting the SetColorScheme action");
+
+            SetColorSchemeArgs args{ L"Vintage" };
+            page->_EndPreviewColorScheme();
+            page->_HandleSetColorScheme(nullptr, ActionEventArgs{ args });
+        });
+
+        TestOnUIThread([&page]() {
+            const auto& activeControl{ page->_GetActiveControl() };
+            VERIFY_IS_NOT_NULL(activeControl);
+
+            const auto& controlSettings = activeControl.Settings().as<TerminalSettings>();
+            VERIFY_IS_NOT_NULL(controlSettings);
+
+            const auto& originalSettings = controlSettings.GetParent();
+            VERIFY_IS_NOT_NULL(originalSettings);
+
+            const auto& grandparentSettings = originalSettings.GetParent();
+            VERIFY_IS_NULL(grandparentSettings);
+
+            Log::Comment(L"Color should be changed");
+            VERIFY_ARE_EQUAL(til::color{ 0xff000000 }, controlSettings.DefaultBackground());
+            VERIFY_ARE_EQUAL(nullptr, page->_originalSettings);
+        });
     }
 
     void TabTests::TestPreviewDismissScheme()
     {
         Log::Comment(L"Preview a color scheme. Make sure it's applied, then dismissed accordingly");
-        VERIFY_IS_TRUE(false, L"TODO: Implement test");
+
+        auto page = _commonSetup();
+        VERIFY_IS_NOT_NULL(page);
+
+        TestOnUIThread([&page]() {
+            const auto& activeControl{ page->_GetActiveControl() };
+            VERIFY_IS_NOT_NULL(activeControl);
+
+            const auto& controlSettings = activeControl.Settings().as<TerminalSettings>();
+            VERIFY_IS_NOT_NULL(controlSettings);
+
+            const auto& originalSettings = controlSettings.GetParent();
+            VERIFY_IS_NOT_NULL(originalSettings);
+
+            VERIFY_ARE_EQUAL(til::color{ 0xff0c0c0c }, controlSettings.DefaultBackground());
+        });
+
+        TestOnUIThread([&page]() {
+            Log::Comment(L"Emulate previewing the SetColorScheme action");
+            SetColorSchemeArgs args{ L"Vintage" };
+            page->_PreviewColorScheme(args);
+        });
+
+        TestOnUIThread([&page]() {
+            const auto& activeControl{ page->_GetActiveControl() };
+            VERIFY_IS_NOT_NULL(activeControl);
+
+            const auto& controlSettings = activeControl.Settings().as<TerminalSettings>();
+            VERIFY_IS_NOT_NULL(controlSettings);
+
+            const auto& previewSettings = controlSettings.GetParent();
+            VERIFY_IS_NOT_NULL(previewSettings);
+
+            const auto& originalSettings = previewSettings.GetParent();
+            VERIFY_IS_NOT_NULL(originalSettings);
+
+            Log::Comment(L"Color should be changed to the preview");
+            VERIFY_ARE_EQUAL(til::color{ 0xff000000 }, controlSettings.DefaultBackground());
+            VERIFY_ARE_EQUAL(originalSettings, page->_originalSettings);
+        });
+
+        TestOnUIThread([&page]() {
+            Log::Comment(L"Emulate dismissing the SetColorScheme action");
+            page->_EndPreviewColorScheme();
+        });
+
+        TestOnUIThread([&page]() {
+            const auto& activeControl{ page->_GetActiveControl() };
+            VERIFY_IS_NOT_NULL(activeControl);
+
+            const auto& controlSettings = activeControl.Settings().as<TerminalSettings>();
+            VERIFY_IS_NOT_NULL(controlSettings);
+
+            const auto& originalSettings = controlSettings.GetParent();
+            VERIFY_IS_NOT_NULL(originalSettings);
+
+            const auto& grandparentSettings = originalSettings.GetParent();
+            VERIFY_IS_NULL(grandparentSettings);
+
+            Log::Comment(L"Color should be the same as it originally was");
+            VERIFY_ARE_EQUAL(til::color{ 0xff0c0c0c }, controlSettings.DefaultBackground());
+            VERIFY_ARE_EQUAL(nullptr, page->_originalSettings);
+        });
     }
 
     void TabTests::TestPreviewSchemeWhilePreviewing()
     {
         Log::Comment(L"Preview a color scheme, then preview another scheme. ");
-        VERIFY_IS_TRUE(false, L"TODO: Implement test");
+
+        Log::Comment(L"Preview a color scheme. Make sure it's applied, then committed accordingly");
+
+        auto page = _commonSetup();
+        VERIFY_IS_NOT_NULL(page);
+
+        TestOnUIThread([&page]() {
+            const auto& activeControl{ page->_GetActiveControl() };
+            VERIFY_IS_NOT_NULL(activeControl);
+
+            const auto& controlSettings = activeControl.Settings().as<TerminalSettings>();
+            VERIFY_IS_NOT_NULL(controlSettings);
+
+            const auto& originalSettings = controlSettings.GetParent();
+            VERIFY_IS_NOT_NULL(originalSettings);
+
+            VERIFY_ARE_EQUAL(til::color{ 0xff0c0c0c }, controlSettings.DefaultBackground());
+        });
+
+        TestOnUIThread([&page]() {
+            Log::Comment(L"Emulate previewing the SetColorScheme action");
+            SetColorSchemeArgs args{ L"Vintage" };
+            page->_PreviewColorScheme(args);
+        });
+
+        TestOnUIThread([&page]() {
+            const auto& activeControl{ page->_GetActiveControl() };
+            VERIFY_IS_NOT_NULL(activeControl);
+
+            const auto& controlSettings = activeControl.Settings().as<TerminalSettings>();
+            VERIFY_IS_NOT_NULL(controlSettings);
+
+            const auto& previewSettings = controlSettings.GetParent();
+            VERIFY_IS_NOT_NULL(previewSettings);
+
+            const auto& originalSettings = previewSettings.GetParent();
+            VERIFY_IS_NOT_NULL(originalSettings);
+
+            Log::Comment(L"Color should be changed to the preview");
+            VERIFY_ARE_EQUAL(til::color{ 0xff000000 }, controlSettings.DefaultBackground());
+            VERIFY_ARE_EQUAL(originalSettings, page->_originalSettings);
+        });
+
+        TestOnUIThread([&page]() {
+            Log::Comment(L"Now, preview another scheme");
+            SetColorSchemeArgs args{ L"One Half Light" };
+            page->_PreviewColorScheme(args);
+        });
+
+        TestOnUIThread([&page]() {
+            const auto& activeControl{ page->_GetActiveControl() };
+            VERIFY_IS_NOT_NULL(activeControl);
+
+            const auto& controlSettings = activeControl.Settings().as<TerminalSettings>();
+            VERIFY_IS_NOT_NULL(controlSettings);
+
+            const auto& previewSettings = controlSettings.GetParent();
+            VERIFY_IS_NOT_NULL(previewSettings);
+
+            const auto& originalSettings = previewSettings.GetParent();
+            VERIFY_IS_NOT_NULL(originalSettings);
+
+            Log::Comment(L"Color should be changed to the preview");
+            VERIFY_ARE_EQUAL(til::color{ 0xffFAFAFA }, controlSettings.DefaultBackground());
+            VERIFY_ARE_EQUAL(originalSettings, page->_originalSettings);
+        });
+
+        TestOnUIThread([&page]() {
+            Log::Comment(L"Emulate commiting the SetColorScheme action");
+
+            SetColorSchemeArgs args{ L"One Half Light" };
+            page->_EndPreviewColorScheme();
+            page->_HandleSetColorScheme(nullptr, ActionEventArgs{ args });
+        });
+
+        TestOnUIThread([&page]() {
+            const auto& activeControl{ page->_GetActiveControl() };
+            VERIFY_IS_NOT_NULL(activeControl);
+
+            const auto& controlSettings = activeControl.Settings().as<TerminalSettings>();
+            VERIFY_IS_NOT_NULL(controlSettings);
+
+            const auto& originalSettings = controlSettings.GetParent();
+            VERIFY_IS_NOT_NULL(originalSettings);
+
+            const auto& grandparentSettings = originalSettings.GetParent();
+            VERIFY_IS_NULL(grandparentSettings);
+
+            Log::Comment(L"Color should be changed");
+            VERIFY_ARE_EQUAL(til::color{ 0xffFAFAFA }, controlSettings.DefaultBackground());
+            VERIFY_ARE_EQUAL(nullptr, page->_originalSettings);
+        });
     }
 
 }
diff --git a/src/cascadia/TerminalSettingsModel/ActionArgs.h b/src/cascadia/TerminalSettingsModel/ActionArgs.h
@@ -498,6 +498,8 @@ namespace winrt::Microsoft::Terminal::Settings::Model::implementation
     struct SetColorSchemeArgs : public SetColorSchemeArgsT<SetColorSchemeArgs>
     {
         SetColorSchemeArgs() = default;
+        SetColorSchemeArgs(winrt::hstring name) :
+            _SchemeName{ name } {};
         WINRT_PROPERTY(winrt::hstring, SchemeName, L"");
 
         static constexpr std::string_view NameKey{ "colorScheme" };
@@ -1045,6 +1047,7 @@ namespace winrt::Microsoft::Terminal::Settings::Model::factory_implementation
     BASIC_FACTORY(NewTabArgs);
     BASIC_FACTORY(MoveFocusArgs);
     BASIC_FACTORY(SplitPaneArgs);
+    BASIC_FACTORY(SetColorSchemeArgs);
     BASIC_FACTORY(ExecuteCommandlineArgs);
     BASIC_FACTORY(CloseOtherTabsArgs);
     BASIC_FACTORY(CloseTabsAfterArgs);

diff --git a/src/cascadia/TerminalSettingsModel/ActionArgs.idl b/src/cascadia/TerminalSettingsModel/ActionArgs.idl
@@ -173,6 +173,7 @@ namespace Microsoft.Terminal.Settings.Model
 
     [default_interface] runtimeclass SetColorSchemeArgs : IActionArgs
     {
+        SetColorSchemeArgs(String name);
         String SchemeName { get; };
     };
-Original file line number
+Diff line change
@@ Expand Up / @@ -173,6 +173,7 @@ namespace Microsoft.Terminal.Settings.Model @@
         [default_interface] runtimeclass SetColorSchemeArgs : IActionArgs
         {
+            SetColorSchemeArgs(String name);
             String SchemeName { get; };
         };
@@ Expand Down @@