Skip to content

Commit

Permalink
Spec for Improved keyboard handling in Conpty (#5887)
Browse files Browse the repository at this point in the history
## Summary of the Pull Request

We have a number of bugs in the Terminal that all have the same singular root cause - VT input does not carry the same fidelity that Win32 input does. For Win32 applications there are certain keystrokes that simply cannot be represented with VT sequences. 

This is my proposal for how we'll handle all these cases. I'm proposing a _new VT sequence_, which will enable the Terminal to send input with all of the information that an `INPUT_RECORD` might have, to conpty. There, conpty will be able to send input to the client application with the same fidelity they're used to, enabling these keys to work for those applications once again. 

## PR Checklist
* [x] Specs #4999
* [x] I work here
* [x] is a spec

## Detailed Description of the Pull Request / Additional comments
_read the spec_
  • Loading branch information
zadjii-msft authored Jun 4, 2020
1 parent 52c0145 commit e1888b0
Show file tree
Hide file tree
Showing 4 changed files with 574 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/actions/spell-check/dictionary/apis.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ bitfields
CLASSNOTAVAILABLE
EXPCMDFLAGS
EXPCMDSTATE
fullkbd
href
IBox
IBind
Expand Down
7 changes: 7 additions & 0 deletions .github/actions/spell-check/expect/expect.txt
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,7 @@ DECAWM
DECCKM
DECCOLM
decf
DECEKBD
DECKPAM
DECKPM
DECKPNM
Expand All @@ -525,6 +526,7 @@ deconstructed
DECPCTERM
DECRC
DECRLM
DECRQM
DECRST
DECSASD
DECSC
Expand All @@ -537,6 +539,7 @@ DECSEL
DECSET
DECSLRM
DECSMBV
DECSMKR
DECSR
decstandar
DECSTBM
Expand Down Expand Up @@ -1163,6 +1166,7 @@ kcub
kcud
kcuf
kcuu
Kd
keith
kernelbase
kernelbasestaging
Expand Down Expand Up @@ -1210,6 +1214,7 @@ LEFTSHIFT
len
lhs
libpopcnt
libtickit
LIMITTEXT
LINEDOWN
LINESELECTION
Expand Down Expand Up @@ -1321,6 +1326,7 @@ MAKELONG
MAKELPARAM
MAKELRESULT
malloc
manpage
MAPBITMAP
MAPVIRTUALKEY
MAPVK
Expand Down Expand Up @@ -1911,6 +1917,7 @@ REGSTR
reingest
Relayout
RELBINPATH
remoting
renderengine
rendersize
reparenting
Expand Down
7 changes: 7 additions & 0 deletions .github/actions/spell-check/expect/web.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,12 @@ www
ecma
rapidtables
WCAG
freedesktop
ycombinator
robertelder
kovidgoyal
leonerd
fixterms
uk
winui
appshellintegration
Loading

0 comments on commit e1888b0

Please sign in to comment.