Skip to content

Commit

Permalink
dead code removal
Browse files Browse the repository at this point in the history
  • Loading branch information
@zadjii-msft
zadjii-msft committed Oct 13, 2023
1 parent d726165 commit e82c627
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 59 deletions.
59 changes: 0 additions & 59 deletions src/cascadia/TerminalApp/TerminalPage.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3931,65 +3931,6 @@ namespace winrt::TerminalApp::implementation
// Create the tab
auto resultPane = std::make_shared<Pane>(*settingsContent);
_settingsTab = _CreateNewTabFromPane(resultPane);

// auto newTabImpl = winrt::make_self<SettingsTab>(sui, _settings.GlobalSettings().CurrentTheme().RequestedTheme());

// // Add the new tab to the list of our tabs.
// _tabs.Append(*newTabImpl);
// _mruTabs.Append(*newTabImpl);

// newTabImpl->SetDispatch(*_actionDispatch);
// newTabImpl->SetActionMap(_settings.ActionMap());

// // Give the tab its index in the _tabs vector so it can manage its own SwitchToTab command.
// _UpdateTabIndices();

// // Don't capture a strong ref to the tab. If the tab is removed as this
// // is called, we don't really care anymore about handling the event.
// auto weakTab = make_weak(newTabImpl);

// auto tabViewItem = newTabImpl->TabViewItem();
// _tabView.TabItems().Append(tabViewItem);

// tabViewItem.PointerPressed({ this, &TerminalPage::_OnTabClick });

// // When the tab requests close, try to close it (prompt for approval, if required)
// newTabImpl->CloseRequested([weakTab, weakThis{ get_weak() }](auto&& /*s*/, auto&& /*e*/) {
// auto page{ weakThis.get() };
// auto tab{ weakTab.get() };
// if (page && tab)
// {
// page->_HandleCloseTabRequested(*tab);
// }
// });

// TODO! Make sure we remove the _settingsTab if it is closed!
// ---------------------- main
// newTabImpl->Closed([weakTab, weakThis{ get_weak() }](auto&& /*s*/, auto&& /*e*/) {
// const auto page = weakThis.get();
// const auto tab = weakTab.get();

// if (page && tab)
// {
// page->_RemoveTab(*tab);
// }
// });
// =======
// // When the tab is closed, remove it from our list of tabs.
// newTabImpl->Closed([tabViewItem, weakThis{ get_weak() }](auto&& /*s*/, auto&& /*e*/) {
// if (auto page{ weakThis.get() })
// {
// page->_settingsTab = nullptr;
// page->_RemoveOnCloseRoutine(tabViewItem, page);
// }
// });
// -------------------------- dev/migrie/fhl/scratchpad-pane

// _settingsTab = *newTabImpl;

//// This kicks off TabView::SelectionChanged, in response to which
//// we'll attach the terminal's Xaml control to the Xaml root.
//_tabView.SelectedItem(tabViewItem);
}
else
{
Expand Down
1 change: 1 addition & 0 deletions src/features.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@
<stage>AlwaysDisabled</stage>
<alwaysEnabledBrandingTokens>
<brandingToken>Dev</brandingToken>
<brandingToken>Canary</brandingToken>
</alwaysEnabledBrandingTokens>
</feature>

Expand Down

1 comment on commit e82c627

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@check-spelling-bot Report

🔴 Please review

See the 📜action log for details.

Unrecognized words (1)

somehown

To accept ✔️ these unrecognized words as correct, run the following commands

... in a clone of the git@github.com:microsoft/terminal.git repository
on the dev/migrie/f/sui-panes branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/terminal/actions/runs/6512109761/attempts/1'
Pattern suggestions ✂️ (1)

You could add these patterns to .github/actions/spelling/patterns/e82c627ebea96bb0ed6e29fcdefba6e973f9b193.txt:

# Automatically suggested patterns
# hit-count: 1 file-count: 1
# tput arguments -- https://man7.org/linux/man-pages/man5/terminfo.5.html -- technically they can be more than 5 chars long...
\btput\s+(?:(?:-[SV]|-T\s*\w+)\s+)*\w{3,5}\b
Warnings (1)

See the 📜action log for details.

ℹ️ Warnings Count
ℹ️ candidate-pattern 1

See ℹ️ Event descriptions for more information.

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

⚠️ The command is written for posix shells. If it doesn't work for you, you can manually add (one word per line) / remove items to expect.txt and the excludes.txt files.

If the listed items are:

  • ... misspelled, then please correct them instead of using the command.
  • ... names, please add them to .github/actions/spelling/allow/names.txt.
  • ... APIs, you can add them to a file in .github/actions/spelling/allow/.
  • ... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
  • ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Please sign in to comment.