Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pencil icon (Edit button) on Actions page is invisible with light theme #10406

Closed
KalleOlaviNiemitalo opened this issue Jun 11, 2021 · 9 comments · Fixed by #10412
Closed

Pencil icon (Edit button) on Actions page is invisible with light theme #10406

KalleOlaviNiemitalo opened this issue Jun 11, 2021 · 9 comments · Fixed by #10412
Assignees
@carlos-zamora
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@KalleOlaviNiemitalo
Copy link

Windows Terminal version (or Windows build number)

Windows Terminal Preview 1.9.1445.0 on Windows 10.0.19043.1052

Other Software

N/A

Steps to reproduce

  1. Select the light theme in Windows settings (Personalization, Colors).
  2. Start Windows Terminal Preview.
  3. Open the Settings tab.
  4. Close the session tab. (Only to exclude it from screen shots.)
  5. Select the Actions page of the Settings tab.
  6. Press the Tab key a few times, to select one of the actions listed.

Expected Behavior

Should have a pencil icon at the right side of the description of the key binding.

The pencil icon would show up all right with a dark theme:

image

Actual Behavior

No pencil icon is visible, but if you press Tab once more, the focus rectangle moves to the invisible pencil icon anyway.

image

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 11, 2021
@KalleOlaviNiemitalo
Copy link
Author

This belongs to the #6900 epic.

The pencil icon is likewise invisible when the mouse pointer hovers on an action while using a light theme.

@KalleOlaviNiemitalo
Copy link
Author

I guess it is caused by the white foreground color here:

terminal/src/cascadia/TerminalSettingsEditor/Actions.xaml

Lines 243 to 250 in 227ec37

<ResourceDictionary x:Key="Light">
<SolidColorBrush x:Key="ButtonForeground"
Color="White" />
<SolidColorBrush x:Key="ButtonForegroundPointerOver"
Color="{StaticResource SystemAccentColor}" />
<SolidColorBrush x:Key="ButtonForegroundPressed"
Color="{StaticResource SystemAccentColor}" />
</ResourceDictionary>

@KalleOlaviNiemitalo KalleOlaviNiemitalo changed the title Pencil icon on Actions page is invisible with light theme Pencil icon (Edit button) on Actions page is invisible with light theme Jun 11, 2021
@mdtauk
Copy link

mdtauk commented Jun 11, 2021

Should be using Theme Resources so the colour changes as the theme does

@KalleOlaviNiemitalo
Copy link
Author

@mdtauk, when I first noticed the invisible icon, I had been using the light theme for several days (perhaps weeks) and even restarted Windows for the June security updates. That makes this bug different from #1230.

@mdtauk
Copy link

mdtauk commented Jun 11, 2021

I wonder if this is an issue about the buttons which appear on hover, not appearing when the control is focused

@KalleOlaviNiemitalo
Copy link
Author

@mdtauk, in that case, the bug would occur with the dark theme as well. It doesn't.

@DHowett
Copy link
Member

DHowett commented Jun 11, 2021

/cc @carlos-zamora

I wonder if this is an issue about the buttons which appear on hover, not appearing when the control is focused

They certainly should appear when the control is focused 😄

@carlos-zamora carlos-zamora self-assigned this Jun 11, 2021
@carlos-zamora carlos-zamora added Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements labels Jun 11, 2021
This was referenced Jun 11, 2021
Open
Merged
@ghost ghost added the In-PR This issue has a related PR label Jun 11, 2021
@ghost ghost closed this as completed in #10412 Jun 14, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jun 14, 2021
ghost pushed a commit that referenced this issue Jun 14, 2021
@carlos-zamora
Fix edit button color in light theme (#10412)
1fcfb61 
## Summary of the Pull Request
Fixes a bug where the edit button in the actions page would have white text when in light theme. Now, we just fallback to XAML's built-in value (black in light theme and white in dark theme).

## References
#6900 - Epic
Closes #10406
DHowett pushed a commit that referenced this issue Jul 7, 2021
@carlos-zamora @DHowett
Fix edit button color in light theme (#10412)
febbf08 
## Summary of the Pull Request
Fixes a bug where the edit button in the actions page would have white text when in light theme. Now, we just fallback to XAML's built-in value (black in light theme and white in dark theme).

## References
#6900 - Epic
Closes #10406

(cherry picked from commit 1fcfb61)
@ghost
Copy link

ghost commented Jul 14, 2021

🎉This issue was addressed in #10412, which has now been successfully released as Windows Terminal v1.9.1942.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 14, 2021

🎉This issue was addressed in #10412, which has now been successfully released as Windows Terminal Preview v1.10.1933.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix edit button color in light theme microsoft/terminal
4 participants
@DHowett @mdtauk @carlos-zamora @KalleOlaviNiemitalo