Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option for tabColor in the colorscheme object #10861

Closed
rashil2000 opened this issue Aug 3, 2021 · 4 comments
Closed

Add an option for tabColor in the colorscheme object #10861

rashil2000 opened this issue Aug 3, 2021 · 4 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@rashil2000
Copy link
Contributor

Description of the new feature/enhancement

The default color for every new tab is either #000000 (dark theme) of #ffffff (light theme). I know there's an option to set tabColor per profile, but I think it'd be pretty neat to make it part of the colorscheme itself.

Proposed technical implementation details (optional)

Just another field in the colorscheme object. The colorscheme object already has three fields that can be overridden in the profile - foreground, background, and cursorColor. tabColor can behave similarly.

Motivation

I like having the tab background flush with the actual background (who doesn't?) so that they seem seamless. As of now it requires specifying the tabColor in each profile which uses a non-default colorscheme. The command palette allows changing colorschemes on the fly, but then you have to manually change the tabColor too.

I'd like to add that this is just a convenience feature request - not really essential.

Cheers!
@rashil2000 rashil2000 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 3, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 3, 2021
@rashil2000
Copy link
Contributor Author

Alternate technical implementation

W.r.t. the motivation specified above, instead of setting the tabColor to either black or white by default, can it read the colorscheme's (either the default colorscheme or the one user has specified in the profile) background property? This behavior can also be made configurable in the form of a global boolean.

@zadjii-msft
Copy link
Member

, instead of setting the tabColor to either black or white by default, can it read the colorscheme's (either the default colorscheme or the one user has specified in the profile) background property?

This is actually almost exactly like the implementation I have proposed (/in progress) for #5772, #3327. More specifically, this sounds like /dup #702

@ghost
Copy link

ghost commented Aug 4, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Aug 4, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 4, 2021
@rashil2000
Copy link
Contributor Author

Oh, so does that mean that making tabColor a part of the colorscheme object is not going to get considered?

@zadjii-msft zadjii-msft mentioned this issue Dec 13, 2023
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zadjii-msft @rashil2000