Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: move the tabColor setting from profile to color-scheme #16465

Open
3SCadmin opened this issue Dec 13, 2023 · 10 comments
Open

Request: move the tabColor setting from profile to color-scheme #16465

3SCadmin opened this issue Dec 13, 2023 · 10 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@3SCadmin
Copy link

Correct me if I am wrong

  • You can change the color-scheme of an open tab
  • But you can not change the profile of an open tab
  • The color of the tab is set with tabColor in the profile (can be also done manually)

In my use case I am opening ssh sessions to different servers. Often 2-3 tabs point at one server and 2-3 other tabs point at another.
I want to mark these tabs so I know at a glance who is who

  • I can change the color-scheme of a tab so that I instinctively know which server I am currently sending commands to.
  • I can change the tab-color manually, so that I know which hidden tab goes to which server.

But that's me choreographing 2 separate actions to achieve one objective.
Logically the tab-color can (should) be part of the color-scheme.

@3SCadmin 3SCadmin added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Dec 13, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 13, 2023

This comment was marked as off-topic.

@microsoft microsoft deleted a comment Dec 13, 2023
@zadjii-msft
Copy link
Member

I'm fairly confident that there's a dupe for this somewhere on the repo, but I can't immediately find it...

@zadjii-msft
Copy link
Member

Ah, #10861 was the dup, but suggested that we just use the theme for this. That's actually a good solution here. If you change the scheme at runtime, I think it should change the background to match.

oh wait but that's not a separate color. Hmm.

@237dmitry
Copy link

237dmitry commented Dec 14, 2023

Logically the tab-color can (should) be part of the color-scheme.

What do I do if several profiles use one color-scheme but different tab colors?
In this case, users will have to clone the color scheme for each profile, but with different tabColor and name parameters.

@3SCadmin
Copy link
Author

What do I do if several profiles use one color-scheme but different tab colors?
In this case, users will have to clone the color scheme for each profile, but with different tabColor and name parameters.

If you use profiles that works. But using different profiles for different tabs mandates that you decide in advance what the new tab will be doing. In my case I am often ssh-ing to different servers .. from different servers. So I may ssh to server A, then form there ssh to server B. I can quickly change the color-scheme of the tab to indicate that this tab is now connected to server B.

Point is: Using Profiles makes sense if you need different shells. But using different profiles just to get a different look is combersome (can't change your mind afterwards)

  • We are already allowed to change the color-scheme of an open tab.
  • conceptually tab-color is closely related to "color-scheme"
  • tab-color can already be set in 2 different places (profile setting and manually) with one overriding the other
    ... so maybe make that 3 places we can set the tab-color? Manual > color-scheme > profile

@237dmitry
Copy link

Different profiles (different shells and TUI applications):

  • using the same color-scheme
  • using different tab colors

If the tabColor parameter is in a color scheme then the user will have to clone this color scheme with different tabColor values for each of the profiles. Therefore, it is more convenient for tabColor to be not part of the color scheme but part of the profile.

I do not know how do you start new tab but you can use --tabcolor #RRGGBB parameter.

wt -w 0 nt --tabColor "#123456" -p "You Profile"

@3SCadmin
Copy link
Author

3SCadmin commented Dec 14, 2023

If the tabColor parameter is in a color scheme then the user will have to clone this color scheme with different tabColor values for each of the profiles.

If tabColor is moved from profile to color-scheme, then Yes
But if we maybe allow it in both, aka Manual > color-scheme > profile
Then the answer is: No you don't need to.

  • All current color-schemes do not have a tabColor value, so the profile setting will prevail
  • If new color-schemes come with a tabColor value, then removing that line (while you are inserting the color-scheme into settings.json) allows the current meta to prevail.

I'm just hoping for the quality of live upgrade where I can change the look of open tabs.

@237dmitry
Copy link

237dmitry commented Dec 14, 2023

At last I understood. If the tab color options will have preferences over each other then your idea is really good.

@3SCadmin
Copy link
Author

At last I understood. If the tab color options will have preferences over each other then your idea is really good.

... the idea got better as the discussion progressed

@237dmitry
Copy link

... the idea got better as the discussion progressed

It would be better to replace “move from profile” with “add to color scheme”.

Imho. Precedence: Manually > Profile > Color Scheme (because parameters of a color scheme are mandatory)

@carlos-zamora carlos-zamora added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 17, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Jan 17, 2024
@carlos-zamora carlos-zamora added the Help Wanted We encourage anyone to jump in on these. label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants