Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region invalidation malfunctioning after text buffer has begun to scroll #11214

Closed
oising opened this issue Sep 13, 2021 · 19 comments
Closed

Region invalidation malfunctioning after text buffer has begun to scroll #11214

oising opened this issue Sep 13, 2021 · 19 comments
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@oising
Copy link
Collaborator

oising commented Sep 13, 2021

Windows Terminal version (or Windows build number)

1.11.2421.0

Other Software

  • Windows 11 / 21H2 / 22000.132

Steps to reproduce

  • open powershell (could be another shell)
  • execute "ls" / "dir" a few times until the text buffer has begun to scroll

Parts (or the entirety) of the buffer should be invisible, yet will be rendered visible if selected with the mouse

e.g.
image

after selection:
image

Expected Behavior

  • text rendered correctly 💩

Actual Behavior

  • text rendered incorrectly
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 13, 2021
@oising oising added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Impact-Compatibility Sure don't work like it used to. Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Tag-Fix Doesn't match tag requirements labels Sep 13, 2021
@zadjii-msft zadjii-msft added Priority-3 A description (P3) Product-Terminal The new Windows Terminal. and removed Impact-Compatibility Sure don't work like it used to. labels Sep 13, 2021
@jessey-git
Copy link

I've also been seeing this since moving to 1.11 preview (usually with various git commands for me). I didn't notice at all in the 1.10 preview so perhaps a regression.

@DHowett DHowett added the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Sep 14, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.12 milestone Sep 22, 2021
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. and removed zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. labels Oct 7, 2021
@zadjii-msft
Copy link
Member

I've been playing with this all morning and can't seem to get a repro. Frankly I haven't seen this once on the 1.11+ selfhost, and I'm not sure anyone else on the team has either. Not sure how we're going to be able to dig in more here without a at least semi-consistent repro.

I'm gonna move this out of 1.12 into 2.0 for now. If it's more widespread, then maybe that'll help us ID a repro. If it's not, then at least that's a good sign.

@oising
Copy link
Collaborator Author

oising commented Oct 7, 2021

My win11 recently updated to 22000.194 (the final release) and I haven't seen it since -- I wonder if it was something more fundamental in the kernel?

@oising
Copy link
Collaborator Author

oising commented Oct 14, 2021

Hmm, I spoke too soon -- it's happening again. I'm on win11 22000.258 now, but I don't know if that's anything to do with it. Could it be something to do with colour output? I'm still on 1.11 for terminal.

image

with selection applied after:

image

@oising
Copy link
Collaborator Author

oising commented Oct 14, 2021

Some more notes:

  • when I draw the selection box, I only have to select the first cell to repair the entire line
  • it does NOT happen on my laptop's (surface book 3) native display, it only happens on my external screen (lg ultrawide)

Could it be DPI related?

image

scaling is 100% on the external screen. My sb3 is at 200% and native resolution.

@jessey-git
Copy link

It could very well be DPI/scaling related (also happens over mstsc connections more often too). At least for me on Win10 here. See below as I can make my current terminal show "missing" lines at will by just dragging between the monitors here.

1080p 100% 4k 200%
2k-100 4k-200

@jessey-git
Copy link

Version 1.12.2931.0 remains broken on Win10 for me.

@kstange
Copy link

kstange commented Nov 5, 2021

I've been seeing this on my second display in the last few days. I'm running on a Surface Book (1st gen) and the terminal fails to render lines only if it's on the external monitor (1080p via DP) which is set to 100% scale. The built-in is set to 175% scale 3000x2000 native resolution and is working fine. It loses a LOT of lines during fast scrolling, often more than 50% of them. The behavior described of highlighting them to get them to reappear works the same as other reports. I have version 1.11.2921.0 from the Windows Store, which last updated Oct 29th.

@oising
Copy link
Collaborator Author

oising commented Nov 18, 2021

In case it's not clear, you can workaround the problem by enabling the "redraw entire screen when display updates" option:

image

@jessey-git
Copy link

1.12.2931.0 still broken

@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@Diu
Copy link

Diu commented Feb 26, 2022

Recently got a 4k monitor (150% scaling), and ran into this issue as well on my secondary monitor (FullHD, no scaling).
When I disable scaling all lines are rendering just fine.

Version: 1.12.10393.0

@zadjii-msft
Copy link
Member

This was also reported in MSFT:38160934.

Alas, for the time being, we still don't have any beat on what triggers this.

I don't recall any rendering changes that would have regressed around 1.11, though.... maybe this is fallout from #9820. That's where I'd look first.

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 1, 2022
@guhetier
Copy link

I could reproduce this consistently by:

  • opening a terminal on one screen
  • running ls
  • moving it to another screen with a different resolution
  • running ls

@zadjii-msft
Copy link
Member

I'm really hoping this was fixed as a side-effect of #12713 (but that hasn't yet been pushed out in a servicing build yet).

@oising
Copy link
Collaborator Author

oising commented Apr 8, 2022

I'm really hoping this was fixed as a side-effect of #12713 (but that hasn't yet been pushed out in a servicing build yet).

From my perspective on how it manifests, that looks hopeful for sure.

@zadjii-msft
Copy link
Member

Hey @oising you still seeing this, like maybe on 1.18/? We've re-written the renderer a couple times since this was filed, I'm thinking this might have gone away on its own 😅

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 15, 2023
@oising
Copy link
Collaborator Author

oising commented Aug 15, 2023

@zadjii-msft Hey Mike! Nope, haven't seen this in a long time. I've got redraw off, s/w off and using the new renderer. I guess close it?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 15, 2023
@oising
Copy link
Collaborator Author

oising commented Aug 15, 2023

Closed as fixed.

@oising oising closed this as completed Aug 15, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

7 participants