Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.12] We can probably just ditch the confirmation dialog when exporting text #11358

Closed
zadjii-msft opened this issue Sep 28, 2021 · 0 comments · Fixed by #11365
Closed

[1.12] We can probably just ditch the confirmation dialog when exporting text #11358

zadjii-msft opened this issue Sep 28, 2021 · 0 comments · Fixed by #11365
Assignees
@zadjii-msft
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.12

Comments

@zadjii-msft
Copy link
Member

discovered in the 1.12 bug bash on 9/28
image

Team discussion was "meh, just remove it"
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) labels Sep 28, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.12 milestone Sep 28, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 28, 2021
@zadjii-msft zadjii-msft self-assigned this Sep 28, 2021
@zadjii-msft zadjii-msft mentioned this issue Sep 29, 2021
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Sep 29, 2021
@ghost ghost closed this as completed in #11365 Oct 1, 2021
ghost pushed a commit that referenced this issue Oct 1, 2021
@zadjii-msft
Replace the UWP file export with the shell32 one (#11365)
85f0674 
Just like in #9760, we can't actually use the UWP file picker API, because it will absolutely not work at all when the Terminal is running elevated. That would prevent the picker from appearing at all. So instead, we'll just use the shell32 one manually. 

This also gets rid of the confirmation dialog, since the team felt we didn't really need that. We could maybe replace it with a Toast (#8592), but _meh_

* [x] closes #11356
* [x] closes #11358
* This is a lot like #9760
* introduced in #11062
* megathread: #9700
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 1, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.12
Development

Successfully merging a pull request may close this issue.

Replace the UWP file export with the shell32 one microsoft/terminal
1 participant
@zadjii-msft