-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background image path not appearing in SUI #11541
Labels
Area-Settings UI
Anything specific to the SUI
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Needs-Triage
It's a new issue that the core contributor team needs to triage at the next triage meeting
Product-Terminal
The new Windows Terminal.
Resolution-Fix-Committed
Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Comments
ghost
added
Needs-Triage
It's a new issue that the core contributor team needs to triage at the next triage meeting
Needs-Tag-Fix
Doesn't match tag requirements
labels
Oct 19, 2021
cinnamon-msft
added
Area-Settings UI
Anything specific to the SUI
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Product-Terminal
The new Windows Terminal.
labels
Oct 20, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 tasks
ghost
pushed a commit
that referenced
this issue
Oct 25, 2021
) ## Summary of the Pull Request Ensures that the background image path is displayed in the settings UI. ## References One of the items on #11353 ## PR Checklist * [x] Closes #11541 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Validation Steps Performed Set the background image path and saw that it was displayed in the settings UI.
ghost
added
Resolution-Fix-Committed
Fix is checked in, but it might be 3-4 weeks until a release.
and removed
In-PR
This issue has a related PR
labels
Oct 25, 2021
DHowett
pushed a commit
that referenced
this issue
Dec 13, 2021
) ## Summary of the Pull Request Ensures that the background image path is displayed in the settings UI. ## References One of the items on #11353 ## PR Checklist * [x] Closes #11541 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Validation Steps Performed Set the background image path and saw that it was displayed in the settings UI. (cherry picked from commit 9662bc6)
DHowett
pushed a commit
that referenced
this issue
Dec 13, 2021
) ## Summary of the Pull Request Ensures that the background image path is displayed in the settings UI. ## References One of the items on #11353 ## PR Checklist * [x] Closes #11541 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Validation Steps Performed Set the background image path and saw that it was displayed in the settings UI. (cherry picked from commit 9662bc6)
🎉This issue was addressed in #11580, which has now been successfully released as Handy links: |
🎉This issue was addressed in #11580, which has now been successfully released as Handy links: |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-Settings UI
Anything specific to the SUI
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Needs-Triage
It's a new issue that the core contributor team needs to triage at the next triage meeting
Product-Terminal
The new Windows Terminal.
Resolution-Fix-Committed
Fix is checked in, but it might be 3-4 weeks until a release.
Windows Terminal version (or Windows build number)
1.12.2861.0
Other Software
No response
Steps to reproduce
Set a background image for a profile.
Expected Behavior
The path should be in the text field.
Actual Behavior
The path doesn't appear in the text field but the background image is still applied.
The text was updated successfully, but these errors were encountered: