Duplicate active half when duplicating split pane #13579

vertigo220 · 2022-07-23T08:28:17Z

Description of the new feature/enhancement

When a pane is split then duplicated, the right half is always the one duplicated. It should duplicate whichever half has focus when right-clicking the tab.

Proposed technical implementation details (optional)

zadjii-msft · 2022-07-23T22:30:41Z

Hmm. This is with the right-click context menu on the tab itself, yea?

Seems like whenever the inactive tab is split, it's like we make a new default profile pane, rather than duplicating the active pane. Curious. Thanks for the bug report! It should probably do the same thing when the tab is inactive, as it does when the tab is active.

vertigo220 · 2022-07-24T00:07:34Z

Yes, but I'm actually referring to the "Duplicate Tab" option. Open a tab, split it, change the directory on one half, then duplicate it, and the new tab created by the duplication has the path of one or the other of the split tab's panes, obviously. The problem is that it's very insistent on using whichever pane it feels like for the path in the new, duplicated tab. When I first tested it, it was always the right pane. Testing again just now, it was the left pane, then somehow I got it to switch to using the path from the right pane and I can't get it to switch back. It should use the path from whichever pane is active when the tab is duplicated.

The same problem applies to splitting an already split tab. The new pane has the same behavior as the new tab created when duplicating, and should have the path of the active pane when the tab is further split.

vertigo220 · 2022-07-25T00:26:11Z

To add to this, I've found more unexpected behavior I think may be related. I have the starting directory for a new tab set to use the parent process directory, which I apparently wrongfully assumed meant the parent tab, but AFAICT it uses the first tab's CWD. This appears to be what issue #3158 deals with, and if that's correct this isn't a bug, but definitely, as mentioned, unexpected. However, what definitely does appear to be a bug is that even duplicating a tab results in the new tab having the CWD of the first tab, and I suspect that's the source of the previously mentioned problems.

4wk- · 2023-03-10T09:17:39Z

Hello. I was about to create my own issue with a somewhate-related subject: shouldn't the "Duplicate tab" duplicate also the split pane layout?
From my understanding, when I right click on a tab that is splitted in 4 ways, I'm expecting the new created tab to be the same: being split in 4.
Am I the only one? Am I missing something?

zadjii-msft · 2023-03-10T14:34:14Z

@4wk- That we're more specifically tracking in a combo of #4674 and #9957.

zadjii-msft · 2023-03-10T14:43:45Z

To add, I think this was fixed at some point in the past. I at least can't repro it on the 1.18 selfhost build build I'm on currently. I'd suspect this was at least fixed in 1.17, probably sooner. I can't really recall which PR fixed this.

Of course, duplicating the CWD of a pane that assumes that you've got shell integration enabled, but this all looks working to me.

I tried both

Open a non-default profile in a second tab
Open a new pane in that tab with another non-default profile
focus the first tab
Right-click inactive tab...split tab -> Always splits the focused pane, and creates a copy of the focused pane

and also

Open a tab,
split it,
change the directory on one half,
then duplicate it -> new tab is created with the profile (and CWD if shell integration is enabled) of the active pane.

4wk- · 2023-03-13T09:13:41Z

@zadjii-msft Thanks for your reply. [EDITED]
I'm not sure I understand you correctly, sorry. I am not talking about CWD at all, I'm talking about the "view/layout" of a given tab. What I am wondering if it's possible is:

open a new tab
right click on tab, and click "Split tab" (so now, we have one tab, split in two panes:
right click on tab, and click "Duplicate tab"

My expectation is: having a new second tab split in two panes too!
(So in total, 2 tabs, and both split in two)

I don't need the CWD to be kept, I'm just talking about tab layout. For my understanding, shell integration enabled is only to enable CWD (current working directory), and not about split tabs. Correct me if I'm wrong!

Sorry again if I'm not clear enough.
I am on Version: 1.16.10261.0 .

4wk- · 2023-03-23T15:26:03Z

@zadjii-msft After more reading, I can confirm that what I'm asking for is #4674: when using the "Duplicate tab" feature, panes should be kept the same (so if a tab is split in 3 panes, "Duplicate tab" should create a new tab with 3 panes in it).
And if I understand correctly, #9957 is needed before #4674 can be worked on. Thanks!

This PR's goal is to allow something like a `Tab` to raise a ShortcutAction, by saying "this action should be performed on ME". We've had a whole category of these issues in the past: * #15734 * #15760 * #13579 * #13942 * #13942 * Heck even dating back to #10832 So, this tries to remove a bit of that footgun. This probably isn't the _final_ form of what this refactor might look like, but the code is certainly better than before. Basically, there's a few bits: * `ShortcutActionDispatch.DoAction` now takes a `sender`, which can be _anything_. * Most actions that use a "Get the focused _thing_ then do something to it" are changed to "If there was a sender, let's use that - otherwise, we'll use the focused _thing_". * TerminalTab was largely refactored to use this, instead of making requests to the `TerminalPage` to just do a thing to it. I've got a few TODO!s left, but wanted to get initial feedback. * [x] `TerminalPage::_HandleTogglePaneZoom` * [x] `TerminalPage::_HandleFocusPane` * [x] `TerminalPage::_MoveTab` Closes #15734

This PR's goal is to allow something like a `Tab` to raise a ShortcutAction, by saying "this action should be performed on ME". We've had a whole category of these issues in the past: * #15734 * #15760 * #13579 * #13942 * #13942 * Heck even dating back to #10832 So, this tries to remove a bit of that footgun. This probably isn't the _final_ form of what this refactor might look like, but the code is certainly better than before. Basically, there's a few bits: * `ShortcutActionDispatch.DoAction` now takes a `sender`, which can be _anything_. * Most actions that use a "Get the focused _thing_ then do something to it" are changed to "If there was a sender, let's use that - otherwise, we'll use the focused _thing_". * TerminalTab was largely refactored to use this, instead of making requests to the `TerminalPage` to just do a thing to it. I've got a few TODO!s left, but wanted to get initial feedback. * [x] `TerminalPage::_HandleTogglePaneZoom` * [x] `TerminalPage::_HandleFocusPane` * [x] `TerminalPage::_MoveTab` Closes #15734 (cherry picked from commit 30eb9ee) Service-Card-Id: 90438493 Service-Version: 1.18

vertigo220 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 23, 2022

ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 23, 2022

zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jul 23, 2022

zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Priority-2 A description (P2) labels Jul 25, 2022

zadjii-msft added this to the Backlog milestone Jul 25, 2022

ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 25, 2022

zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 26, 2022

This was referenced Sep 8, 2022

Duplicating inactive tab duplicates active one #13942

Closed

Selected tab title not used for Export Text file name #13948

Closed

zadjii-msft closed this as completed Mar 10, 2023

microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Mar 10, 2023

zadjii-msft added Resolution-Fix-Available It's available in an Insiders build or a release and removed Needs-Tag-Fix Doesn't match tag requirements labels Mar 10, 2023

zadjii-msft mentioned this issue Jul 27, 2023

Raise ShortcutActions with the sender (tab, control) context #15773

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Duplicate active half when duplicating split pane #13579

Duplicate active half when duplicating split pane #13579

vertigo220 commented Jul 23, 2022

zadjii-msft commented Jul 23, 2022

vertigo220 commented Jul 24, 2022

vertigo220 commented Jul 25, 2022

4wk- commented Mar 10, 2023

zadjii-msft commented Mar 10, 2023

zadjii-msft commented Mar 10, 2023

4wk- commented Mar 13, 2023 •

edited

Loading

4wk- commented Mar 23, 2023

Duplicate active half when duplicating split pane #13579

Duplicate active half when duplicating split pane #13579

Comments

vertigo220 commented Jul 23, 2022

Description of the new feature/enhancement

Proposed technical implementation details (optional)

zadjii-msft commented Jul 23, 2022

vertigo220 commented Jul 24, 2022

vertigo220 commented Jul 25, 2022

4wk- commented Mar 10, 2023

zadjii-msft commented Mar 10, 2023

zadjii-msft commented Mar 10, 2023

4wk- commented Mar 13, 2023 • edited Loading

4wk- commented Mar 23, 2023

4wk- commented Mar 13, 2023 •

edited

Loading