-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Elements not rendering correctly with AtlasEngine enabled #14098
Comments
Might be same underlying issue as #14022 |
Note to self/team: The block character scaling technique in
This doesn't work with fonts that use side bearings for block characters. A better way would be to assume that all fonts that define any block character also probably define the U+2588 Full Block character. That way we can do:
|
This commit makes the following improvements: * Only adjust block characters that come from fallback fonts. This ensures that the glyphs of the chosen font all look exactly as they were designed. * When adjusting the size, use the fallback font's full block glyph U+2588 to determine the size that the given glyph should have. Closes #14098 ## Validation Steps Performed * Print `UTF-8-demo.txt` in Consolas. * All block glyphs look uniform. ✅
@lhecker, while I agree your change is correctly called
|
@Dan-Albrecht Somewhat "late" in the development cycle I changed the algorithm so that it doesn't touch characters found in the given user font. My intention was that glyphs in the user's font remain untouched. If we don't do that this leads to other display issues (incorrect alginment, etc.). U+2594 is part of Cascadia Mono and so it won't get "adjusted" to fit the cell and I forgot to re-test it as part of the PR, focusing only on Consolas, etc. Not sure what to do about this issue now: I should try to see if it helps to round up ascend/descend after all. But I'm not certain we can merge that - people have complained in the past when I did that. Otherwise we'll either have to wait for the next big AtlasEngine update which brings support for overlapping glyphs, or support for line height adjustments (which I'm submitting tomorrow). |
This commit makes the following improvements: * Only adjust block characters that come from fallback fonts. This ensures that the glyphs of the chosen font all look exactly as they were designed. * When adjusting the size, use the fallback font's full block glyph U+2588 to determine the size that the given glyph should have. Closes #14098 ## Validation Steps Performed * Print `UTF-8-demo.txt` in Consolas. * All block glyphs look uniform. ✅ (cherry picked from commit 97abc3d) Service-Card-Id: 86159056 Service-Version: 1.16
🎉This issue was addressed in #14099, which has now been successfully released as Handy links: |
Windows Terminal version
1.16.2642.0
Windows build number
10.0.22000.0
Other Software
No response
Steps to reproduce
In PowerShell with the default Cascadia Mono font, run:
Write-Host "`u{2595}`u{2594}`n`u{2595}`u{2581}"
Expected Behavior
In version 1.15.2525.0 or 1.16.2642.0 with AtlasEngine disabled:
Actual Behavior
The top is cut off:
The text was updated successfully, but these errors were encountered: