Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the setting "confirmCloseAllTabs" to the UI #14413

Closed
Tracked by #10000
ElitePheonix2009 opened this issue Nov 20, 2022 · 2 comments · Fixed by #14419
Closed
Tracked by #10000

Add the setting "confirmCloseAllTabs" to the UI #14413

ElitePheonix2009 opened this issue Nov 20, 2022 · 2 comments · Fixed by #14419
Labels
Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@ElitePheonix2009
Copy link

Description of the new feature/enhancement

The setting "confirmCloseAllTabs" should be added to the ui so that it can be easily found.

Proposed technical implementation details (optional)
@ElitePheonix2009 ElitePheonix2009 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 20, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 20, 2022
@zadjii-msft zadjii-msft mentioned this issue Nov 21, 2022
Open
65 tasks
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-SettingsUI Anything specific to the SUI and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Nov 21, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 21, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Nov 21, 2022
@zadjii-msft
Copy link
Member

Huh, we didn't have one for this one. Good catch!

There was some discussion about this in #10000

  • these might not make sense in SUI. I think we'd prefer to add a checkbox or something to the warning dialogs saying "don't show this again". So maybe we want to deprecate these settings?
  • zadjii note: I think these do make sense in the SUI. We need to expose ways to reveal the state of the application, including if these warnings have been disabled. I'd put these under "Interaction"

leejy12 added a commit to leejy12/terminal that referenced this issue Nov 21, 2022
@leejy12
Add the setting "confirmCloseAllTabs" to SUI
e97a844 
Closes microsoft#14413
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 21, 2022
@leejy12 leejy12 mentioned this issue Nov 21, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Nov 21, 2022
@ghost ghost closed this as completed in #14419 Nov 21, 2022
@ghost ghost removed the In-PR This issue has a related PR label Nov 21, 2022
ghost pushed a commit that referenced this issue Nov 21, 2022
@leejy12
Add the setting "confirmCloseAllTabs" to SUI (#14419)
437b5ac 
This commit adds the setting "confirmCloseAllTabs" to SUI.
The setting was added to the Interactions pane of Global Settings.

Closes #14413
Closes #14033
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Nov 21, 2022
DHowett pushed a commit that referenced this issue Dec 12, 2022
@leejy12 @DHowett
Add the setting "confirmCloseAllTabs" to SUI (#14419)
b73718a 
This commit adds the setting "confirmCloseAllTabs" to SUI.
The setting was added to the Interactions pane of Global Settings.

Closes #14413
Closes #14033

(cherry picked from commit 437b5ac)
Service-Card-Id: 87207138
Service-Version: 1.16
@ghost
Copy link

ghost commented Dec 14, 2022

🎉This issue was addressed in #14419, which has now been successfully released as Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add the setting "confirmCloseAllTabs" to SUI leejy12/terminal
2 participants
@zadjii-msft @ElitePheonix2009