Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider rewording the new confirmCloseAllTabs SUI setting #14433

Closed
DHowett opened this issue Nov 23, 2022 · 2 comments · Fixed by #14473
Closed

Consider rewording the new confirmCloseAllTabs SUI setting #14433

DHowett opened this issue Nov 23, 2022 · 2 comments · Fixed by #14473
Labels
Area-SettingsUI Anything specific to the SUI good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.17

Comments

@DHowett
Copy link
Member

DHowett commented Nov 23, 2022 

    For clarity this might be better stated as, "Confirm when closing more than one tab". We cannot always translate the JSON names directly to sentences :smile:

EDIT: or even, "Prompt for confirmation before closing more than one tab"?

Originally posted by @DHowett in #14419 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 23, 2022
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-3 A description (P3) good first issue This is a fix that might be easier for someone to do as a first contribution Area-SettingsUI Anything specific to the SUI labels Nov 28, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 28, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.17 milestone Nov 28, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 28, 2022
@crazo7924
Copy link
Contributor

How about this

Warn on closing multiple tabs

crazo7924 added a commit to crazo7924/terminal that referenced this issue Dec 1, 2022
@crazo7924
reword en-US value for confirmCloseAllTabs
9e5a7c0 
Giving a warning sounds better in my opinion.

attempts to fix microsoft#14433
@crazo7924 crazo7924 mentioned this issue Dec 1, 2022
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Dec 1, 2022
DHowett pushed a commit that referenced this issue Dec 9, 2022
@crazo7924
reword en-US value for confirmCloseAllTabs (#14473)
86aa666 
Fixes #14433
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Needs-Tag-Fix Doesn't match tag requirements and removed In-PR This issue has a related PR labels Dec 9, 2022
DHowett pushed a commit that referenced this issue Dec 12, 2022
@crazo7924 @DHowett
reword en-US value for confirmCloseAllTabs (#14473)
bc860a9 
Fixes #14433

(cherry picked from commit 86aa666)
Service-Card-Id: 87207139
Service-Version: 1.16
@ghost
Copy link

ghost commented Dec 14, 2022

🎉This issue was addressed in #14473, which has now been successfully released as Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-SettingsUI Anything specific to the SUI good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.17
Development

Successfully merging a pull request may close this issue.

reword en-US value for confirmCloseAllTabs crazo7924/terminal
3 participants
@DHowett @zadjii-msft @crazo7924