Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open with Terminal option when inside a Zip on Explorer #15190

Closed
SoulPancake opened this issue Apr 16, 2023 · 3 comments · Fixed by #15236
Closed

Open with Terminal option when inside a Zip on Explorer #15190

SoulPancake opened this issue Apr 16, 2023 · 3 comments · Fixed by #15236
Assignees
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal.
Milestone

Comments

@SoulPancake
Copy link

Windows Terminal version

1.12.10983.0

Windows build number

10.0.22624.0

Other Software

No response

Steps to reproduce

On windows 11
If you open a zip file directly and you're within the folder of the extracted zip via explorer
then on right clicking you get the Open With Terminal option but clicking that doesn't do anything

Expected Behavior

It should either eliminate the option itself or return an alert or an error
Or it should somehow trace the directory of the actual temporary folder where it extracts the zip and open that up via the terminal on clicking the option

Actual Behavior

Clicking on it does nothing but the option remains so it feels like bug

@SoulPancake SoulPancake added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 16, 2023
@jamespack
Copy link
Contributor

jamespack commented Apr 23, 2023

I think this is fairly easy to fix. We can check if an item is both a folder and a stream and if so disable the command.

https://learn.microsoft.com/en-us/windows/win32/shell/sfgao?redirectedfrom=MSDN&f1url=%3FappId%3DDev16IDEF1%26l%3DEN-US%26k%3Dk(SHOBJIDL_CORE%252FSFGAO_FILESYSTEM)%3Bk(SFGAO_FILESYSTEM)%3Bk(SolutionItemsProject)%3Bk(SolutionItemsProject)%3Bk(DevLang-C%252B%252B)%3Bk(TargetOS-Windows)%26rd%3Dtrue

Happy to PR it. Unless you want to do something more sophisticated than that :)

@SoulPancake
Copy link
Author

@jamespack This sounds good for me

@zadjii-msft
Copy link
Member

Yep, we're cool just disabling it in this case. Really seems like this is something that the modern file explorer extensions should have caught for us, but 🤷

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. Area-ShellExtension For issues related to the explorer right-click context menu labels Apr 25, 2023
@zadjii-msft zadjii-msft added this to the Backlog milestone Apr 25, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Apr 25, 2023
DHowett pushed a commit that referenced this issue Apr 25, 2023
Closes #15190

(cherry picked from commit fea6eed)
Service-Card-Id: 89001983
Service-Version: 1.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants