-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to mute sound effect for failed tab completion in CMD #15870
Comments
What's your |
In addition, there are some shells that call the operating system functions |
This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. |
@zadjii-msft @DHowett , thanks for the replies. @zadjii-msft , it's the same for any combination of settings. I guess the CMD is a shell that directly calls the |
Unfortunately, it looks like it is! It calls We're going to triage this as an issue in CMD; however, know that we are pretty hesitant to make changes there since CMD is "critical infrastructure". |
@DHowett I'm tempted to just close this out - you know our policy on CMD.exe changes. Literally NEVER not burned by it. We also don't have a "Man if one day we could make cmd.exe changes" megathread (at least, not a public one I could find). I can make one and link this to it, but I don't want people to think this is something we can fix anytime soon. |
My first thought was that this wouldn't be a risky change, but then I remembered https://xkcd.com/1172/. There's bound to be someone somewhere that has patched the user32 dll to hook the |
It also changes the visible (on |
#15870 (comment) is an important note I think deserves to be committed.
@zadjii-msft , @DHowett , @j4james , Thanks for your look at the issue and the entertaining conversation. 😄 I understand that this might be an overly risky change, especially since I can work around it by using the mute button or I have no issue if you want to close it. Maybe add a note somewhere about limitations of the bell settings. Thanks! EDIT: It looks like @zadjii-msft already added a note to the FAQ. Speedy! |
Thanks for the discussion, and for being OK with us closing it. I'd love to fix it, but honestly I've been burned by CMD changes too many times. :laugh: |
#15870 (comment) is an important note I think deserves to be committed.
Windows Terminal version
1.17.11461.0
Windows build number
10.0.19045.3324
Other Software
No response
Steps to reproduce
1 - Create a tab for a CMD shell.
2 - type
cd NonExistent<TAB>
, triggers the "asterisk" sound, unaffected by the pertinent settings in the Volume Mixer.In the volume mixer, the sound is shown as a "System Sound", not as part of the WindowsTerminal.
This is unaffected by any/all "Bell notification" setting(s).
Same behavior is seen in the most recent preview version of WindowsTerminal.
Expected Behavior
I expected "Bell notification" settings to be honored for the sound.
Actual Behavior
"Asterisk" system sound is triggered.
The text was updated successfully, but these errors were encountered: