Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-running just the tests will fail in CI, even if the tests pass #15876

Closed
zadjii-msft opened this issue Aug 24, 2023 · 1 comment · Fixed by #15877
Closed

Re-running just the tests will fail in CI, even if the tests pass #15876

zadjii-msft opened this issue Aug 24, 2023 · 1 comment · Fixed by #15877
Assignees
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products.

Comments

@zadjii-msft
Copy link
Member

Probably regressed in #15808

Case in point:

PR: https://github.com/microsoft/terminal/pull/15867/checks?check_run_id=16176312961.
AZP: https://dev.azure.com/ms/terminal/_build/results?buildId=491204&view=logs&jobId=715ae6b5-7bc1-5485-dd41-2ac3c0010e51&j=715ae6b5-7bc1-5485-dd41-2ac3c0010e51&t=efe7f887-b87a-5492-dbfa-782df7fade32.

Log:

Starting: PublishPipelineArtifact
==============================================================================
Task         : Publish Pipeline Artifacts
Description  : Publish (upload) a file or directory as a named artifact for the current run
Version      : 1.199.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/publish-pipeline-artifact
==============================================================================
Artifact name input: test-logs-x64-Release
Uploading pipeline artifact from D:\a\_work\1\a\Release\x64\test-logs for build #491204
Using default max parallelism.
Max dedup parallelism: 192
ApplicationInsightsTelemetrySender will correlate events with X-TFS-Session 20065d8c-75d0-4839-8a6f-1fb162ba1281
Hashtype: Dedup64K
DedupManifestArtifactClient will correlate http requests with X-TFS-Session 20065d8c-75d0-4839-8a6f-1fb162ba1281
1 files processed.
Processed 1 files from D:\a\_work\1\a\Release\x64\test-logs successfully.
Uploaded 1,703,262 out of 1,703,262 bytes
Content upload is done!

Content upload statistics:
Total Content: 3.4 MB
Physical Content Uploaded: 0.1 MB
Logical Content Uploaded: 1.7 MB
Compression Saved: 1.6 MB
Deduplication Saved: 1.7 MB
Number of Chunks Uploaded: 17
Total Number of Chunks: 49

ApplicationInsightsTelemetrySender correlated 2 events with X-TFS-Session 20065d8c-75d0-4839-8a6f-1fb162ba1281
##[error]Artifact test-logs-x64-Release already exists for build 491204.
Finishing: PublishPipelineArtifact

The first run, tests flaked out. On rerun, they passed. But the CI reported it as a failure, because Artifact test-logs-x64-Release already exists for build 491204

@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Meta The product is the management of the products. labels Aug 24, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.19 milestone Aug 24, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 24, 2023
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 24, 2023
@DHowett
Copy link
Member

DHowett commented Aug 24, 2023

Oh, interesting. This is an unexpected limitation in Azure DevOps! I wonder if there's a way to disambiguate the pipeline artifact...

@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Aug 24, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Aug 24, 2023
DHowett added a commit that referenced this issue Aug 30, 2023
Closes #15876

(cherry picked from commit b024efb)
Service-Card-Id: 90368681
Service-Version: 1.17
DHowett added a commit that referenced this issue Aug 30, 2023
Closes #15876

(cherry picked from commit b024efb)
Service-Card-Id: 90368682
Service-Version: 1.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants