Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COOKED_READ: Backspacing over control visualizers (^W) deletes 4 glyphs #16356

Closed
lhecker opened this issue Nov 22, 2023 · 0 comments · Fixed by #16400
Closed

COOKED_READ: Backspacing over control visualizers (^W) deletes 4 glyphs #16356

lhecker opened this issue Nov 22, 2023 · 0 comments · Fixed by #16400
Labels
Area-CookedRead The cmd.exe COOKED_READ handling In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Conhost For issues in the Console codebase zInbox-Bug Ignore me!
Milestone
Terminal v1.20

Comments

@lhecker
Copy link
Member

lhecker commented Nov 22, 2023

Windows Terminal version

63b3820

Windows build number

No response

Other Software

No response

Steps to reproduce

  • Launch cmd
  • Ctrl+W
  • Backspace

Expected Behavior

Deletes 2 glyphs.

Actual Behavior

Deletes 4 glyphs
@lhecker lhecker added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-0 Bugs that we consider release-blocking/recall-class (P0) Area-CookedRead The cmd.exe COOKED_READ handling zInbox-Bug Ignore me! labels Nov 22, 2023
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 29, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.20 milestone Nov 29, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Nov 29, 2023
@zadjii-msft zadjii-msft added the Product-Conhost For issues in the Console codebase label Nov 29, 2023
@lhecker lhecker mentioned this issue Nov 30, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Nov 30, 2023
DHowett pushed a commit that referenced this issue Dec 4, 2023
@lhecker
Fix backspacing over control visualizers (#16400)
654b755 
During `!measureOnly` the old code would increment `distance` twice.
Now it doesn't. :)

Closes #16356

## Validation Steps Performed
See updated test instructions in `doc/COOKED_READ_DATA.md`
DHowett pushed a commit that referenced this issue Dec 4, 2023
@lhecker @DHowett
Fix backspacing over control visualizers (#16400)
e33de75 
During `!measureOnly` the old code would increment `distance` twice.
Now it doesn't. :)

Closes #16356

## Validation Steps Performed
See updated test instructions in `doc/COOKED_READ_DATA.md`

(cherry picked from commit 654b755)
Service-Card-Id: 91232745
Service-Version: 1.19
@j4james j4james mentioned this issue Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CookedRead The cmd.exe COOKED_READ handling In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Conhost For issues in the Console codebase zInbox-Bug Ignore me!
Projects
None yet
Milestone
Terminal v1.20
Development

Successfully merging a pull request may close this issue.

Fix backspacing over control visualizers microsoft/terminal
2 participants
@lhecker @zadjii-msft