Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT doesn't support U+2068 and U+2069 characters #16574

Open
KexyBiscuit opened this issue Jan 19, 2024 · 3 comments
Open

WT doesn't support U+2068 and U+2069 characters #16574

KexyBiscuit opened this issue Jan 19, 2024 · 3 comments
Labels
Area-AtlasEngine Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone

Comments

@KexyBiscuit
Copy link

KexyBiscuit commented Jan 19, 2024

Windows Terminal version

1.20.10161.0

Windows build number

10.0.26020.1000

Other Software

AOSC OS on WSL

Steps to reproduce

  1. Install AOSC OS on WSL from Microsoft Store
  2. Finish the OOBE
  3. Run sudo oma refresh

Expected Behavior

The output is fully human readable.

Actual Behavior

Several unreadable characters appear, specifically U+2068 and U+2069.

These characters are for Explicit Directional Isolates. Microsoft's doc also mentions these characters. It seems that Windows Terminal doesn't support them, and just print the characters out.

image

@KexyBiscuit KexyBiscuit added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 19, 2024
@zadjii-msft
Copy link
Member

@lhecker you're more familiar with unicode than I - this is basically a dup of #538, yea?

@KexyBiscuit
Copy link
Author

Just added the screenshot, I think it's partially a duplicate, but what I care the most is to improve readability, not to actually support that Unicode feature.

@lhecker
Copy link
Member

lhecker commented Jan 19, 2024

I believe we can consider this part of #538 even if automatic directionality has not been mentioned yet there. The reason this occurs is because we don't yet analyze the input text for directional markers at all. I'll leave this issue open though, because I want to suppress rendering these glyphs in a hotfix first. Afterwards we can continue tracking the overall issue in #538.

BTW: I see that the numeric parameter for OMA's packages-can-be-upgrade message is also wrapped in a FSI/PDI pair. It probably shouldn't do that, since the number is part of the sentence and some text rendering approaches look a bit weird if you change the directionality of text more than once per paragraph.

KexyBiscuit added a commit to AOSC-Dev/oma that referenced this issue Jan 20, 2024
KexyBiscuit added a commit to AOSC-Dev/oma that referenced this issue Jan 20, 2024
eatradish pushed a commit to AOSC-Dev/oma that referenced this issue Jan 20, 2024
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Area-AtlasEngine and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 24, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Jan 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Tag-Fix Doesn't match tag requirements labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AtlasEngine Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants