Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to open Windows Terminal any more #16747

Closed
cmarkwick365 opened this issue Feb 21, 2024 · 41 comments · Fixed by #16939
Closed

Unable to open Windows Terminal any more #16747

cmarkwick365 opened this issue Feb 21, 2024 · 41 comments · Fixed by #16939
Assignees
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Severity-Crash Crashes are real bad news.

Comments

@cmarkwick365
Copy link

Windows Terminal version

1.19.10302.0

Windows build number

10.0.22631.3155

Other Software

No response

Steps to reproduce

I'm getting a similar issue as #16730 . I don't have macType. I just click on terminal from the start menu and nothing happens. The dialog doesn't even flash up, and nothing in the event log.

Expected Behavior

Should open

Actual Behavior

The odd thing is that if I open Powershell (x64) it will open. But if I try to open a new tab, it crashes with this:

Faulting application name: WindowsTerminal.exe, version: 1.19.2401.30002, time stamp: 0x65b9ada4
Faulting module name: Windows.UI.Xaml.dll, version: 10.0.22621.3155, time stamp: 0xa0b6eeba
Exception code: 0xc000027b
Fault offset: 0x0000000000873530
Faulting process id: 0x0x71E8
Faulting application start time: 0x0x1DA65063E2CFEFC
Faulting application path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.19.10302.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe
Faulting module path: C:\Windows\System32\Windows.UI.Xaml.dll
Report Id: 49a8f447-eb8c-4473-94b1-5c94f3088e53
Faulting package full name: Microsoft.WindowsTerminal_1.19.10302.0_x64__8wekyb3d8bbwe
Faulting package-relative application ID: App

@cmarkwick365 cmarkwick365 added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 21, 2024
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@cmarkwick365
Copy link
Author

Btw I already tried repairing and uninstalling/re-installing.

@carlos-zamora
Copy link
Member

Thanks for filing. Could you capture a trace using Feedback Hub? This'll help us look into the issue further.

/feedback

@zadjii-msft
Copy link
Member

<bot hat>

Hi there!

Can you please send us feedback with the Feedback Hub with this issue? Make sure to click the "Start recording" button, then reproduce the issue before submitting the feedback. Once it's submitted, paste the link here so we can more easily find your crash information on the back end?

Thanks!

image

image

image

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 21, 2024
@cmarkwick365
Copy link
Author

Captured on Feedback Hub

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 22, 2024
@c0ony
Copy link

c0ony commented Feb 23, 2024

I am having the same issue on a fresh win 11. It was working on this computer with no issues before a bad GPU install wrecked everything and I was forced to do a full reinstall of win11. Now, the terminal won't open at all, even though I can open PowerShell and Command Prompt with no issues.

@carlos-zamora
Copy link
Member

Captured on Feedback Hub

Thanks! Would you mind sharing the link so we could look at it?

@carlos-zamora carlos-zamora added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Feb 28, 2024
@Exsshly
Copy link

Exsshly commented Feb 29, 2024

Reinstall Terminal, try to turn off Settings-Rendering-Use the new text renderer("AtlasEngine") may help.

@cmarkwick365
Copy link
Author

@Samary1999 I already had renderer("AtlasEngine") set.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 29, 2024
@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Feb 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Mar 4, 2024
@cmarkwick365
Copy link
Author

Waiting for feedback. Still an issue.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Mar 4, 2024
@zadjii-msft
Copy link
Member

@cmarkwick365 When you filed feedback, you need to click this button:
https://user-images.githubusercontent.com/18221333/62478649-6de55400-b760-11e9-806e-5aab7e085a9f.png

And paste the link it generates here. Otherwise, it's impossible for us to find the feedback you filed. Thanks!

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Mar 4, 2024
@cmarkwick365
Copy link
Author

@zadjii-msft Here is the feedback link
https://aka.ms/AApeuqb

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention The core contributors need to come back around and look at this ASAP. label Mar 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Mar 19, 2024
@lhecker
Copy link
Member

lhecker commented Mar 20, 2024

@mhjartstrom @jmpecx The option to disable AtlasEngine will go away in the future. Could you please assist me in figuring out why it crashes? To do so, please enable AtlasEngine again and send me a crash dump. You can find my email address in my GitHub profile. Here's how to enable crash dumps: https://github.com/microsoft/terminal/wiki/Troubleshooting-Tips#capture-automatically

@cmarkwick365
Copy link
Author

cmarkwick365 commented Mar 20, 2024

@lhecker Email sent with dump file.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 20, 2024
@zadjii-msft zadjii-msft added the Severity-Crash Crashes are real bad news. label Mar 20, 2024
@lhecker lhecker self-assigned this Mar 20, 2024
@mhjartstrom
Copy link

@lhecker Email sent with dump file.

@lhecker
Copy link
Member

lhecker commented Mar 21, 2024

@mhjartstrom Thanks for the dump! Unfortunately I can't quite pinpoint the origin of the heap corruption. Would you be willing to help me further test this?

If so, one thing I'd like to test is whether Windows Terminal Canary crashes for you. You can install it here: https://aka.ms/terminal-canary-installer
After installing it, make sure it has imported all your settings from your regular Windows Terminal. (Otherwise open the settings file with Ctrl+Shift+, in both applications and copy it over.)

@mhjartstrom
Copy link

@lhecker OK, I've sent another crash dump for when using Windows Terminal Canary.

@cmarkwick365
Copy link
Author

@lhecker resent dump file. Canary had the same behavior.

@cmarkwick365
Copy link
Author

@lhecker I take it that you noticed this in the dump I sent?
FAILURE_BUCKET_ID: STOWED_EXCEPTION_XAML_TEXT_Class_not_registered_80040154_Microsoft.UI.Xaml.dll!winrt::hresult_error::hresult_error

@lhecker
Copy link
Member

lhecker commented Mar 22, 2024

@cmarkwick365 For others it's crashing due to a heap corruption, but your terminal is crashing in an entirely different place. I believe your system may be corrupted, because I can see:

*** WARNING: Check Image - Checksum mismatch - Dump: 0x12261cd, File: 0x1226255 - C:\Symbols\sym\Windows.UI.Xaml.dll\E6498AA71226000\Windows.UI.Xaml.dll

I would suggest checking your system with chkdsk, dism and sfc. For instance:

chkdsk C: /f
dism /Online /Cleanup-image /Restorehealth
sfc /scannow

If it is a corruption of Windows.UI.Xaml.dll, it may be necessary to reinstall Windows. I'm not 100% sure if it's a corruption though - I certainly haven't seen this warning before.


@mer30hamid @mhjartstrom I'll address you both in this comment, because I've asked both of you for dumps and both of you have heap corruptions.

Coincidentally, you also both use 8+ year old Intel Graphics drivers. Can you check if there's a newer driver available for you? You can find instructions on how to find the latest drivers here: https://www.intel.com/content/www/us/en/support/articles/000005629/graphics/processor-graphics.html

In theory it should be one of these 2 drivers: https://www.intel.com/content/www/us/en/search.html#sort=relevancy&f:@tabfilter=[Downloads]&f:@stm_10385_en=[Graphics,Processor%20Graphics,Intel%C2%AE%20HD%20Graphics%20Family]&f:@operatingsystem_en=[Windows%2011%20Family*]
(I know I selected Windows 11 there, but I think this is fine. If you go to each of the driver's pages it'll say that it's compatible with Windows 10.)

@mer30hamid
Copy link

@cmarkwick365 For others it's crashing due to a heap corruption, but your terminal is crashing in an entirely different place. I believe your system may be corrupted, because I can see:

*** WARNING: Check Image - Checksum mismatch - Dump: 0x12261cd, File: 0x1226255 - C:\Symbols\sym\Windows.UI.Xaml.dll\E6498AA71226000\Windows.UI.Xaml.dll

I would suggest checking your system with chkdsk, dism and sfc. For instance:

chkdsk C: /f
dism /Online /Cleanup-image /Restorehealth
sfc /scannow

If it is a corruption of Windows.UI.Xaml.dll, it may be necessary to reinstall Windows. I'm not 100% sure if it's a corruption though - I certainly haven't seen this warning before.

@mer30hamid @mhjartstrom I'll address you both in this comment, because I've asked both of you for dumps and both of you have heap corruptions.

Coincidentally, you also both use 8+ year old Intel Graphics drivers. Can you check if there's a newer driver available for you? You can find instructions on how to find the latest drivers here: https://www.intel.com/content/www/us/en/support/articles/000005629/graphics/processor-graphics.html

In theory it should be one of these 2 drivers: https://www.intel.com/content/www/us/en/search.html#sort=relevancy&f:@tabfilter=[Downloads]&f:@stm_10385_en=[Graphics,Processor%20Graphics,Intel%C2%AE%20HD%20Graphics%20Family]&f:@operatingsystem_en=[Windows%2011%20Family*] (I know I selected Windows 11 there, but I think this is fine. If you go to each of the driver's pages it'll say that it's compatible with Windows 10.)

I tried to update my intel graphic driver but no update available for it, I have dual graphic processor and switched to NVIDIA and problem is gone!

image

@mhjartstrom
Copy link

@lhecker There is no newer Intel graphics card driver as far as I can tell. But it's working splendidly without the AtlasEngine, so I take it that this is caused by something that you do, not that Intel does?

@lhecker
Copy link
Member

lhecker commented Mar 25, 2024

It's unfortunate to hear that the newer drivers don't work for you! I was hoping you two would be using a 6th gen Intel CPU or newer, because then you could use the 30.* series drivers that I've linked above.

But it's working splendidly without the AtlasEngine, so I take it that this is caused by something that you do, not that Intel does?

Graphics drivers run in user-mode nowadays, within each process (within WindowsTerminal.exe). If the driver has a bug then this can cause the application to crash. Normally, I wouldn't assume that it's a driver bug, but given that @mer30hamid can resolve this issue by simply switching to his Nvidia GPU, it makes me very, very suspicious of your Intel GPU drivers. AtlasEngine has no vendor-specific code, so no matter whether you use your Intel or any other GPU, the exact same code with the exact same inputs should be running. If it's crashing with one GPU driver but not the other then this is somewhat suspicious.

The reason it works when AtlasEngine is disabled is because the older text renderer is based on Direct2D which uses older and simpler graphics APIs. However, AtlasEngine has an internal mode to use Direct2D as well, which is currently only activated when it runs on very old GPUs.

So my idea to resolve your issue is to simply add a setting to Windows Terminal that forces it to use Direct2D for rendering. @mhjartstrom If you want to help test my idea can you try running these commands?

d3dconfig apps --add WindowsTerminal.exe
d3dconfig device feature-level-limit=9_3

Afterwards, restart Windows Terminal. Does it still crash then?

When you're done with testing I would recommend running

d3dconfig --reset --confirm

and disabling AtlasEngine again.

@mer30hamid
Copy link

can you try running these commands?

d3dconfig apps --add WindowsTerminal.exe
d3dconfig device feature-level-limit=9_3

Yes!

Afterwards, restart Windows Terminal. Does it still crash then?

No ! no crash anymore even I enabled the "AtlasEngine" option

After running this command: d3dconfig --reset --confirm windows terminal crashed again by resizing, so I disabled "AtlasEngine" again.

@mhjartstrom
Copy link

... @mhjartstrom If you want to help test my idea can you try running these commands?

d3dconfig apps --add WindowsTerminal.exe
d3dconfig device feature-level-limit=9_3

Afterwards, restart Windows Terminal. Does it still crash then?

I would very much like to help out, as I'm eager to have this issue resolved, but now I'm on vacation two weeks starting today... I'll be sure to try this out as soon as I'm back - if you still want me to, or are you on a deadline for this?

github-merge-queue bot pushed a commit that referenced this issue Mar 26, 2024
This implements `SetForceFullRepaintRendering` and adds a new
`SetGraphicsAPI` function. The former toggles `Present1` on and off
and the latter allows users to explicitly request Direct2D/3D.

On top of these changes I did a minor cleanup of the interface,
because now that DxRenderer is gone we don't need all that anymore.

Closes #14254
Closes #16747

## Validation Steps Performed
* Toggling Direct2D on/off changes colored ligature support ✅
* Toggling Present1 on/off can be observed in a debugger ✅
* Toggling WARP on/off changes GPU metrics ✅

---------

Co-authored-by: Dustin L. Howett <duhowett@microsoft.com>
@mhjartstrom
Copy link

... @mhjartstrom If you want to help test my idea can you try running these commands?

d3dconfig apps --add WindowsTerminal.exe
d3dconfig device feature-level-limit=9_3

Afterwards, restart Windows Terminal. Does it still crash then?

I would very much like to help out, as I'm eager to have this issue resolved, but now I'm on vacation two weeks starting today... I'll be sure to try this out as soon as I'm back - if you still want me to, or are you on a deadline for this?

For reference, it indeed does seem to resolve the issue to use the mentioned d3dconfig commands.

@cmarkwick365
Copy link
Author

Windows Terminal started working again for me again. Whatever was in the latest release must have fixed it.

@zhangbaozhe
Copy link

Reinstall Terminal, try to turn off Settings-Rendering-Use the new text renderer("AtlasEngine") may help.

This worked. I opened Windows Terminal in Admin mode and changed the settings. It worked. Thanks!

@cmarkwick365
Copy link
Author

Reinstall Terminal, try to turn off Settings-Rendering-Use the new text renderer("AtlasEngine") may help.

This worked. I opened Windows Terminal in Admin mode and changed the settings. It worked. Thanks!

That wasn't the issue. It resolved itself after an update.

@lhecker
Copy link
Member

lhecker commented Jun 8, 2024

Many of you are probably using MacType which had a bug that made us crash (to be clear, it's not a bug in Windows Terminal). Since this comes up relatively often, we have recently added some code to detect the outdated MacType versions here: #17369

The latest MacType version contains the fix: https://github.com/snowie2000/mactype/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Severity-Crash Crashes are real bad news.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants