Feature request: option to remove profile icon completely #17943
Assignees
Labels
Area-Settings
Issues related to settings and customizability, for console or terminal
In-PR
This issue has a related PR
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Needs-Tag-Fix
Doesn't match tag requirements
Product-Terminal
The new Windows Terminal.
Milestone
Comments
pwthutch
added
the
Issue-Feature
microsoft-github-policy-service
bot
added
Needs-Tag-Fix
carlos-zamora
added
Issue-Bug
|
Huh. 4ff38c2 should have introduced support for We've marked this up as a bug. Thanks! |
|
@carlos-zamora I would be interested in working on this! |
Thanks for you interest @LouizaMak! I'm already working in this space though with #17965 (and I plan on fixing it as a part of that PR). I suggest working on a different issue. Issues tagged as "Help-Wanted" (see this query) would be a good place to start 😊 Also, we're happy to take PRs, so no need to comment on the issue you're interested in. Just get coding and open a PR on our repo. Excited to see it come in! |
microsoft-github-policy-service
bot
added
the
Needs-Tag-Fix
DHowett
pushed a commit
that referenced
this issue
Oct 17, 2024
The settings UI and settings model allow you to set the icon to "none" to hide the icon (you can actually see this effect in the settings UI when changing the value of the profile icon). However, during settings validation, "none" is considered a file path, which is then failed to be parsed, resulting in the icon being marked as invalid and immediately clearing the value. This PR fixes this issue by considering "none" to be an accepted value during validation. Related to #15843 Closes #17943 ## Validation Steps Performed When an icon is set to "none", ... ✅ no more warning ✅ the icon is hidden (cherry picked from commit 36f064c) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgTyV8A Service-Version: 1.21
DHowett
pushed a commit
that referenced
this issue
Oct 17, 2024
The settings UI and settings model allow you to set the icon to "none" to hide the icon (you can actually see this effect in the settings UI when changing the value of the profile icon). However, during settings validation, "none" is considered a file path, which is then failed to be parsed, resulting in the icon being marked as invalid and immediately clearing the value. This PR fixes this issue by considering "none" to be an accepted value during validation. Related to #15843 Closes #17943 ## Validation Steps Performed When an icon is set to "none", ... ✅ no more warning ✅ the icon is hidden (cherry picked from commit 36f064c) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgTyV8E Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the new feature/enhancement
Provide an option in settings.json to remove the icon for a profile completely, and reclaim the space in the tab bar to display (more of) the profile's name/tab title.
Use case: I routinely work with a large number of open tabs, in which case the profile icon takes up between 1/3 to 1/2 of the available tab width, meaning only the first 3-4 characters of the window title are shown. This is insufficient for me to quickly identify and switch between open tabs.
While I do appreciate the cute row of Tux-en at top of my screen :) (most of my tabs are ssh sessions to remote Linux machines), I'd rather have the real-estate used more productively.
Tried the following to achieve this in 1.21, without success:
"icon": ""in the profile definition -> causes WT to throw an error about invalid icon path"icon": nullin the profile definition -> does nothing; the inbuilt default icon for the profile will still be usedProposed technical implementation details (optional)
"icon": "none","icon": ""or similar to be set in the profile definitionThe text was updated successfully, but these errors were encountered: