Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conpty: produce a NuGet package (for internal consumption, for now) #3577

Closed
1 task done
DHowett-MSFT opened this issue Nov 14, 2019 · 0 comments · Fixed by #12980
Closed
1 task done

conpty: produce a NuGet package (for internal consumption, for now) #3577

DHowett-MSFT opened this issue Nov 14, 2019 · 0 comments · Fixed by #12980
Assignees
@DHowett
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Conpty For console issues specifically related to conpty Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented Nov 14, 2019 •
edited by DHowett
Loading

see also: #1130
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 14, 2019
@DHowett-MSFT DHowett-MSFT added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Conpty For console issues specifically related to conpty Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 14, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 14, 2019
@DHowett-MSFT DHowett-MSFT self-assigned this Nov 14, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Nov 14, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Nov 23, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Apr 13, 2020
Closed
@DHowett DHowett assigned DHowett and unassigned DHowett-MSFT May 17, 2020
@DHowett DHowett mentioned this issue Nov 29, 2020
Closed
This was referenced Dec 2, 2021
Open
Closed
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@DHowett DHowett mentioned this issue Apr 26, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Apr 26, 2022
@ghost ghost closed this as completed in #12980 Apr 27, 2022
@ghost ghost removed the In-PR This issue has a related PR label Apr 27, 2022
ghost pushed a commit that referenced this issue Apr 27, 2022
@DHowett
Build a NuGet Package for ConPTY (#12980)
9611433 
This pull request introduces a packaging phase that emits
Microsoft.Windows.Console.ConPTY, a nuget package that contains the
pseudoconsole API as well as the requisite copies of conhost.

* winconpty learned to load a version of OpenConsole.exe specific to the
  processor architecture on its hosting machine
* the package, as well as its contents, is signed properly and is nearly
  ready for distribution via nuget.org
* the API in conpty-static.h has been adjusted to expose
  CreatePseudoConsoleAsUser and stamp out the correct DLL import/export
  annotations.
* getting .NET to play right was somewhat challenging, but I tested this
  against .NET 6.0 and it seemed to work properly; it shipped conpty.dll
  in the right places, and it shipped OpenConsole.exe next to the
  published application.

In the future, we could provide an interop assembly for C# consumers;
that is, unfortunately, out of scope today.

Closes #3577
Closes #3568
Obsoletes #1130
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 27, 2022
This was referenced Mar 29, 2023
Closed
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Conpty For console issues specifically related to conpty Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Build a NuGet Package for ConPTY microsoft/terminal
3 participants
@DHowett @DHowett-MSFT @zadjii-msft