Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen on secondary display has has more than double the expected width #3785

Closed
krage opened this issue Nov 30, 2019 · 2 comments
Closed
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Milestone

Comments

@krage
Copy link

krage commented Nov 30, 2019

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 0.7.3291.0

Two displays on same nvidia GPU (441.41 drivers). Primary is 2560x1440, secondary positioned to the left is 1920x1200.

Steps to reproduce

Use powershell $Host.UI.RawUI.WindowSize to check dimensions of terminal both maximized and fullscreen.

Expected behavior

Fullscreen terminal should report at most a handful of extra rows/cols compared to a maximized window (accounting for space consumed by window border/task bar).

Actual behavior

For primary monitor as expected:
Maximized: 229x61
Fullscreen: 231x63

On secondary monitor gigantic width in fullscreen:
Maximized: 171x50
Fullscreen: 348x52

The fullscreen window itself is still correctly sized to the display. The left/top/bottom edges of the terminal content are aligned to the matching edges of the window (or approximately when fullscreened directly from maximized ala #3709). The extra columns aren't visible beyond the right edge of the window.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 30, 2019
@DHowett-MSFT DHowett-MSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 2, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 2, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal-1912 milestone Dec 2, 2019
@DHowett-MSFT
Copy link
Contributor

This may (???) be helped by #3721?

@krage
Copy link
Author

krage commented Dec 3, 2019

I've built a copy of that branch in #3721 and it does appear to fix this behavior for me.

I removed my settings file to directly compare the powershell-reported dimensions of the built-in defaults across both:

Release Build

Primary Display Maximized 280x64
Primary Display Fullscreen (from non-maximized) 280x67
Primary Display Fullscreen (from maximized) 283x67
Secondary Display Maximized 209x52
Secondary Display Fullscreen (from non-maximized) 423x56
Secondary Display Fullscreen (from maximized) 425x55

#3721 Build

Primary Display Maximized 280x64
Primary Display Fullscreen (from non-maximized) 280x67
Primary Display Fullscreen (from maxmimized) 280x67
Secondary Display Maximized 209x52
Secondary Display Fullscreen (from non-maximized) 209x56
Secondary Display Fullscreen (from maximized) 209x56

So can confirm on my setup at least that it fixes both the incorrect width on secondary display and the fullscreen from maximize issues.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jan 6, 2020
@cinnamon-msft cinnamon-msft added Resolution-Fix-Available It's available in an Insiders build or a release and removed Needs-Tag-Fix Doesn't match tag requirements labels Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Projects
None yet
Development

No branches or pull requests

3 participants