Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entering Fullscreen from Maximized doesn't work right #3709

Closed
zadjii-msft opened this issue Nov 26, 2019 · 6 comments · Fixed by #3721
Closed

Entering Fullscreen from Maximized doesn't work right #3709

zadjii-msft opened this issue Nov 26, 2019 · 6 comments · Fixed by #3721
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v0.8

Comments

@zadjii-msft
Copy link
Member

Moved from #3707

Environment

Windows build number: 10.0.18363.0 Microsoft Windows NT 10.0.18363.0

Windows Terminal version (if applicable): 0.7.3291.0

Another behavior is that when going into Full-Screen mode from a maximized window, you still see the taskbar and the padding around the shell looks all messed up:

image

fullscreens to:

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 26, 2019
@OmriSama
Copy link

Thanks @zadjii-msft !

@zadjii-msft zadjii-msft mentioned this issue Nov 26, 2019
Closed
@OmriSama
Copy link

I should also mention that I use three monitors at work, and my 4k monitor (my third, as opposed to the other two being 1080p) displays a different behavior when fullscreening:

Not maximized -> fullscreen:
image

Maximized -> fullscreen:
image

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Nov 26, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 26, 2019
@zadjii-msft zadjii-msft added the Priority-3 A description (P3) label Nov 26, 2019
@zadjii-msft zadjii-msft mentioned this issue Nov 26, 2019
Closed
@beviu beviu mentioned this issue Nov 26, 2019
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Nov 26, 2019
@shanselman
Copy link
Member

Yep, I hit this within minutes. :(

@nicolaskeller
Copy link

Fullscreen looks good if padding is set to 8,8,8,8.
If padding is set to 0,0,0,0 the content gets cut.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 30, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal-1912 milestone Nov 30, 2019
@krage krage mentioned this issue Nov 30, 2019
Closed
@nathpete-msft
Copy link
Member

Interestingly, this issue (including the 4k monitor issue mentioned by @OmriSama) only repros for me if I have showTabsInTitlebar enabled. With that setting off switching to fullscreen works as expected regardless of the starting window state or the monitor it's on.

@ghost ghost closed this as completed in #3721 Dec 16, 2019
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Dec 16, 2019
ghost pushed a commit that referenced this issue Dec 16, 2019
@beviu
Use WS_POPUP for NonClientIslandWindow instead of overriding WM_NCCAL…
abb2df1 
…CSIZE to remove borders (#3721)

<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request

Fixes the sides disappearing when entering full screen mode when the window is maximized.
However, now, a Vista-style frame briefly appears when entering/exiting full screen.

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #3709
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [x] Requires documentation to be updated (no)
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

When the non-client island window is maximized and has the WS_OVERLAPPEDWINDOW style, SetWindowPos is "lying": the position ends up being offset compared to the one we gave it (found by debugging). So I changed it to use WS_POPUP like the client island window was already doing. But now it has the Vista frame that appears briefly when entering/exiting full screen like the client island window.

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
@zadjii-msft zadjii-msft mentioned this issue Dec 30, 2019
Closed
@ghost
Copy link

ghost commented Jan 14, 2020

🎉This issue was addressed in #3721, which has now been successfully released as Windows Terminal Preview v0.8.10091.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v0.8
Development

Successfully merging a pull request may close this issue.

Fix fullscreen after maximize
6 participants
@shanselman @OmriSama @DHowett-MSFT @zadjii-msft @nicolaskeller @nathpete-msft