Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ConPty understand more types of input #4873

Closed
carlos-zamora opened this issue Mar 10, 2020 · 3 comments · Fixed by #5383
Closed

Make ConPty understand more types of input #4873

carlos-zamora opened this issue Mar 10, 2020 · 3 comments · Fixed by #5383
Assignees
@carlos-zamora
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conpty For console issues specifically related to conpty Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Console Backlog

Comments

@carlos-zamora
Copy link
Member

carlos-zamora commented Mar 10, 2020 •
edited by DHowett-MSFT
Loading

Work item introduced by #4856.

For now, as long as conpty can parse AppKeys and some mouse events, we don't need to turn input passthrough off. Since the VT is only passed through if the app is ready for it (denoted by ENABLE_VIRTUAL_TERMINAL_INPUT), we stop the VT Input at InputStateMachineEngine. So it should be OK. Not ideal, but it works.

when we fix this, revert or remove the fix for #4911
@carlos-zamora carlos-zamora added Product-Conpty For console issues specifically related to conpty Area-Input Related to input processing (key presses, mouse, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. labels Mar 10, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 10, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 13, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.x milestone Mar 13, 2020
@DHowett-MSFT
Copy link
Contributor

Triaged into Console Backlog.

@DHowett-MSFT DHowett-MSFT mentioned this issue Mar 13, 2020
Closed
@DHowett-MSFT
Copy link
Contributor

When we fix this, revert the fix for #4911.

@carlos-zamora carlos-zamora mentioned this issue Apr 16, 2020
Merged
1 task
@ghost ghost added the In-PR This issue has a related PR label Apr 16, 2020
@ghost ghost closed this as completed in #5383 Apr 17, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 17, 2020
ghost pushed a commit that referenced this issue Apr 17, 2020
@carlos-zamora
Add SS3 cursor key encoding to ConPty (#5383)
f1fe4c6 
## Summary of the Pull Request
Adds SS3 cursor encoding for cursor keys and home/end button. Reverts a portion of #4913 that checks for VT Input Mode.

## PR Checklist
* [X] Closes #4873

## Validation Steps Performed
1. Open pwsh
2. run `wsl`
3. execute `printf "\e[?1h"`
4. verify keys work
5. exit back to pwsh
6. verify keys work still (didn't previously)

Also verified that those keys work in vim when connected to my Raspberry Pi over SSH.
@DHowett-MSFT DHowett-MSFT mentioned this issue Apr 22, 2020
Closed
@ghost
Copy link

ghost commented Apr 22, 2020

🎉This issue was addressed in #5383, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Input Related to input processing (key presses, mouse, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conpty For console issues specifically related to conpty Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Console Backlog
Development

Successfully merging a pull request may close this issue.

Add SS3 cursor key encoding to ConPty microsoft/terminal
2 participants
@carlos-zamora @DHowett-MSFT