Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename requestedTheme to theme #5264

Closed
DHowett-MSFT opened this issue Apr 6, 2020 · 1 comment · Fixed by #5265
Closed

Rename requestedTheme to theme #5264

DHowett-MSFT opened this issue Apr 6, 2020 · 1 comment · Fixed by #5265
Assignees
@carlos-zamora
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@DHowett-MSFT
Copy link
Contributor

Because requestedTheme isn't a good name, and theme as a generic name has the potential for future expansion (to take an object, depending on how #3327 lands), I propose we do the above renaming.

"theme": "light"
"theme": "dark"
"theme": "system"
"theme": { "object, later"... }

In the future, we can seamlessly transition to a theme-enlightened world by introducing themes named "light", "dark" and "system" in whatever the theming system #3327 introduces evolves into.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 6, 2020
@DHowett-MSFT DHowett-MSFT added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 7, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 7, 2020
@carlos-zamora carlos-zamora mentioned this issue Apr 7, 2020
Merged
1 task
@ghost ghost added the In-PR This issue has a related PR label Apr 7, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Apr 7, 2020
@ghost ghost closed this as completed in #5265 Apr 7, 2020
@ghost ghost removed the In-PR This issue has a related PR label Apr 7, 2020
ghost pushed a commit that referenced this issue Apr 7, 2020
@carlos-zamora
Rename 'requestedTheme' to 'theme' (#5265)
7c7db79 
## Summary of the Pull Request

Renames the `requestedTheme` global setting to `theme`. Propagates updates to...
- schema
- doc
- defaults.json
- universal-defaults.json
 
## PR Checklist
* [X] Closes #5264 

## Validation Steps Performed
| `theme` | Success? |
|--|--|
| `system` | ✔ |
| `light` | ✔ |
| `dark` | ✔ |

But we really know that `dark` is the one we care about here 😉
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 7, 2020
@ghost
Copy link

ghost commented Apr 22, 2020

🎉This issue was addressed in #5265, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Rename 'requestedTheme' to 'theme' microsoft/terminal
2 participants
@carlos-zamora @DHowett-MSFT