Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color Picker Regression: new tab button is white on light theme #5741

Closed
DHowett-MSFT opened this issue May 4, 2020 · 0 comments · Fixed by #5749
Closed

Color Picker Regression: new tab button is white on light theme #5741

DHowett-MSFT opened this issue May 4, 2020 · 0 comments · Fixed by #5749
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.1

Comments

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented May 4, 2020 •
edited by zadjii-msft
Loading

image

Regressed in #3789
@DHowett-MSFT DHowett-MSFT added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-1 A description (P1) labels May 4, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.1 milestone May 4, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 4, 2020
@zadjii-msft zadjii-msft mentioned this issue May 5, 2020
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label May 5, 2020
@ghost ghost removed the In-PR This issue has a related PR label May 5, 2020
DHowett-MSFT pushed a commit that referenced this issue May 5, 2020
@zadjii-msft
Don't set the new tab button colors for now (#5749)
7a251d8 
This is actually related to another issue we have, #3917. I think if the system is set to "Dark" theme, but the app is set to light theme, then the brush lookup in `_ClearNewTabButtonColor` still returns to us the dark theme brushes.

Fortunately, since we're not actually setting the color of the new tab button anymore, we can just remove the call to that method now, and loop back on it later.

## References
* regressed in #3789 
* related to #3917

## PR Checklist
* [x] Closes #5741
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label May 5, 2020
jelster pushed a commit to jelster/terminal that referenced this issue May 28, 2020
@zadjii-msft @jelster
Don't set the new tab button colors for now (microsoft#5749)
0a4e448 
This is actually related to another issue we have, microsoft#3917. I think if the system is set to "Dark" theme, but the app is set to light theme, then the brush lookup in `_ClearNewTabButtonColor` still returns to us the dark theme brushes.

Fortunately, since we're not actually setting the color of the new tab button anymore, we can just remove the call to that method now, and loop back on it later.

## References
* regressed in microsoft#3789 
* related to microsoft#3917

## PR Checklist
* [x] Closes microsoft#5741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.1
Development

Successfully merging a pull request may close this issue.

Don't set the new tab button colors for now microsoft/terminal
1 participant
@DHowett-MSFT