Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: option to hide tab icons #8157

Closed
wdscxsj opened this issue Nov 4, 2020 · 7 comments · Fixed by #15948
Closed

Feature request: option to hide tab icons #8157

wdscxsj opened this issue Nov 4, 2020 · 7 comments · Fixed by #15948
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-Theming Anything related to the theming of elements of the window good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@wdscxsj
Copy link

wdscxsj commented Nov 4, 2020 •
edited
Loading

Description of the new feature/enhancement

The "compact" tab width mode hides inactive tab titles and only shows icons for them. With multiple tabs of a same profile, it's hard to tell the difference without a descriptive title (which is controllable from the shell).

A "compact" thing means to pack enough information into a small space, often in an unattractive way. A workaround is to use a non-existent "icon" target for all profiles in settings.json, but that's hacky, and doesn't save enough space as expected. Let's compare Terminal and ConEmu, both snapped to the right half side of my screen:

Screenshot046

Thus I propose a new tab width mode, say "textOnly", that hides icons (even for the active tab) and shows compact titles only.
@wdscxsj wdscxsj added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 4, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 4, 2020
@zadjii-msft
Copy link
Member

Thanks for the request! This is something that I've already got written down as an idea for #3327, so I'll make sure to link the two up ☺️

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Nov 4, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 4, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Nov 4, 2020
@zadjii-msft zadjii-msft mentioned this issue Nov 4, 2020
Open
27 tasks
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 4, 2020
@austin-beer
Copy link

I would love to see this feature implemented as well. Hopefully some progress can be made on this as part of #3327.

@zadjii-msft zadjii-msft added Area-Theming Anything related to the theming of elements of the window and removed Area-UserInterface Issues pertaining to the user interface of the Console or Terminal labels Aug 4, 2021
@zadjii-msft zadjii-msft moved this to Should be written in Terminal Walkthroughs Feb 6, 2023
@zadjii-msft
Copy link
Member

Note

Walkthrough

I'm gonna combine this with a related ask for monochrome tab icons.

  • Start by modifying the Tab Theme object.
    • Add an IconStyle enum to Theme.idl, with Default, Hidden and Monochrome as options.
    • add a new property to TabTheme in Theme.idl. Icon which accepts an "IconStyle".
    • In MTSMSettings.h, add a new setting under MTSM_THEME_TAB_SETTINGS. The key for this one should just be "iconStyle"
  • Actually use this new setting
    • TerminalTab::UpdateIcon is probably the right place for this. You probably want to add another parameter to this.
    • IconPathConverter::IconSourceMUX may need some plumbing to support colored OR monochrome icons.

@zadjii-msft zadjii-msft moved this from Should be written to Walkthrough in issue in Terminal Walkthroughs Aug 23, 2023
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. good first issue This is a fix that might be easier for someone to do as a first contribution labels Aug 23, 2023
@zadjii-msft zadjii-msft modified the milestones: Up Next, Backlog Aug 23, 2023
@BenConstable9
Copy link
Contributor

@zadjii-msft can I attempt to pick this up shortly?

@zadjii-msft
Copy link
Member

Go for it ☺️

@zadjii-msft
Copy link
Member

(you can also skip the monochrome bit if you want. I put that in the original spec because "I'm sure someone out there wants this" but I'm not actually sure anyone does)

@bundgaard
Copy link
Contributor

bundgaard commented Sep 10, 2023 •
edited
Loading

To clarify, we want to be able to hide the icon in the tab control, and also make it monochrome, We do not change the compact mode, as the code supposedly is in another project.

To implement this functionality we would have to add a monochrome filter and hide the icon altogether based on the respective setting.
I hope I understood it correctly.

@bundgaard bundgaard mentioned this issue Sep 10, 2023
Merged
4 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Sep 11, 2023
zadjii-msft pushed a commit that referenced this issue Sep 19, 2023
@bundgaard
Option to default to show icon in tab, hide tabicon or make icon in t…
394b942 
…ab monochrome. (#15948)

Adding enum iconstyle for hiding the icon in the tab #8157 

## Summary of the Pull Request
Please confirm if I am on the right track.
## References and Relevant Issues

## Detailed Description of the Pull Request / Additional comments

## Validation Steps Performed

## PR Checklist
- [ ] Closes #8157
- [x] Tests added/passed
- [ ] Documentation updated
- If checked, please file a pull request on [our docs
repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
- [ ] Schema updated (if necessary)
@github-project-automation github-project-automation bot moved this from Walkthrough in issue to Done in Terminal Walkthroughs Sep 19, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-Theming Anything related to the theming of elements of the window good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
Terminal Walkthroughs
Status: Done
Milestone
Backlog
5 participants
@bundgaard @wdscxsj @BenConstable9 @zadjii-msft @austin-beer