Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab tooltip is empty when zooming pane #8199

Closed
mpela81 opened this issue Nov 9, 2020 · 3 comments · Fixed by #8298
Closed

Tab tooltip is empty when zooming pane #8199

mpela81 opened this issue Nov 9, 2020 · 3 comments · Fixed by #8298
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@mpela81
Copy link
Contributor

mpela81 commented Nov 9, 2020

Environment

Microsoft Windows [Version 10.0.19041.572]

Windows Terminal version (if applicable): dev mainline

Steps to reproduce

  • Split pane
  • Zoom pane
  • Hover on the tab

Expected behavior

The tooltip shows the active title

Actual behavior

The tooltip is blank
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 9, 2020
@mpela81
Copy link
Contributor Author

mpela81 commented Nov 9, 2020 •
edited
Loading

As I can see it, when pane is zoomed the tab's header is set with a StackPanel including zoom icon and title, instead of just the title. The tooltip isn't shown automatically in that case.

Fix may be just setting the tooltip explicitly in this case.
Edit: well, if we set the tooltip explicitly we may have to always keep it in sync with the title, so that it changes when you unzoom and select another pane..

@zadjii-msft
Copy link
Member

Good catch!

Maybe when we're thinking about doing this, we should add a little blurb like "(zoomed)" or "15%" (for the progress in #6700) to the tooltip as well

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Nov 9, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 9, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Nov 9, 2020
@DHowett DHowett added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 9, 2020
@ghost ghost mentioned this issue Nov 17, 2020
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Nov 17, 2020
@ghost ghost closed this as completed in #8298 Dec 17, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Dec 17, 2020
ghost pushed a commit that referenced this issue Dec 17, 2020
@kaihugo
Set Tab tooltip explicitly (#8298)
b8e6b8e 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
The tab tooltip is no longer empty when it was toggle zoomed.
<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #8199 
* [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
@ghost
Copy link

ghost commented Jan 28, 2021

🎉This issue was addressed in #8298, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.:tada:

Handy links:

mpela81 pushed a commit to mpela81/terminal that referenced this issue Jan 28, 2021
@kaihugo @mpela81
Set Tab tooltip explicitly (microsoft#8298)
2583d8f 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
The tab tooltip is no longer empty when it was toggle zoomed.
<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes microsoft#8199 
* [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Set Tab tooltip explicitly
3 participants
@DHowett @mpela81 @zadjii-msft