Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right-click paste preserves the selection, but keyboard paste clears it #8729

Closed
KalleOlaviNiemitalo opened this issue Jan 9, 2021 · 5 comments · Fixed by #8742
Closed

Right-click paste preserves the selection, but keyboard paste clears it #8729

KalleOlaviNiemitalo opened this issue Jan 9, 2021 · 5 comments · Fixed by #8742
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@KalleOlaviNiemitalo
Copy link

Environment

Windows build number: Microsoft Windows [Version 10.0.19042.685]
Windows Terminal version (if applicable): Windows Terminal Preview Version: 1.5.3242.0

Steps to reproduce

  1. Configure "copyOnSelect": true.
  2. Open a Command Prompt session in Windows Terminal.
  3. Type the longest wait.
  4. Press Home to move the cursor to the start of the command.
  5. Double-click longest to select it. Windows Terminal copies longest to the clipboard, as well.
  6. Click the right mouse button to paste longest.

Expected behavior

longestthe longest wait, where nothing is selected.

Actual behavior

longestthe longest wait, where estthe is selected.

Justification

If you change step 6 to paste by pressing Ctrl+Shift+V or Shift+Insert, instead of clicking the right mouse button, then Windows Terminal clears the selection. It feels inconsistent that pasting with the keyboard clears the selection but pasting with the mouse preserves it, especially when pasting also changes the text in the selected cells.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 9, 2021
@KalleOlaviNiemitalo
Copy link
Author

#3884 is for copying and this one is for pasting.

@zadjii-msft
Copy link
Member

You're right, mouse pasting probably should also clear the selection. Thanks!

@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Jan 11, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 11, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Jan 11, 2021
@Don-Vito
Copy link
Contributor

@zadjii-msft - I can do it

@Don-Vito Don-Vito mentioned this issue Jan 11, 2021
Merged
@ghost ghost added In-PR This issue has a related PR Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 11, 2021
ghost pushed a commit that referenced this issue Jan 12, 2021
@Don-Vito
Fix right-click paste to clear current selection (#8742)
20fc57e 
Closes #8729
@ghost ghost closed this as completed in #8742 Jan 12, 2021
DHowett pushed a commit that referenced this issue Jan 25, 2021
@Don-Vito @DHowett
Fix right-click paste to clear current selection (#8742)
fd2b3f7 
Closes #8729

(cherry picked from commit 20fc57e)
@ghost
Copy link

ghost commented Jan 28, 2021

🎉This issue was addressed in #8742, which has now been successfully released as Windows Terminal v1.5.10271.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 28, 2021

🎉This issue was addressed in #8742, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.:tada:

Handy links:

mpela81 pushed a commit to mpela81/terminal that referenced this issue Jan 28, 2021
@Don-Vito @mpela81
Fix right-click paste to clear current selection (microsoft#8742)
d74b692 
Closes microsoft#8729
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Fix right-click paste to clear current selection Don-Vito/terminal
3 participants
@Don-Vito @zadjii-msft @KalleOlaviNiemitalo