Remove or fix "Use parent process directory" checkbox

[cinnamon-msft]

In the main branch right now in the settings UI, there's a checkbox called "Use parent process directory" underneath Starting directory. This checkbox is intended to behave as if the Starting directory were empty. If you click the checkbox, it will empty and disable the textbox for Starting directory.

I am personally in favor of removing this checkbox and putting in the Starting directory tooltip that leaving the field blank will use the parent process directory. The checkbox adds extra confusion to the setting.

If people are adamant about keeping it, its functionality should be fixed slightly: if the Starting directory box is emptied, the checkbox should immediately be checked.

Therefore, this scenario shouldn't be possible.

[carlos-zamora]

Tagging @PankajBhojwani since he implemented this (PR).

[PankajBhojwani]

Based on #8761 I thought the checkbox design was what we were going for!

Also, if you empty the textbox and hit 'Apply', the checkbox will automatically get checked - the reason it doesn't automatically get checked before you hit apply is because otherwise the user will not be able to clear out the textbox and type in a whole new path (clear out text box -> checkbox gets immediately checked -> text box gets disabled). Also, the user will not be able to uncheck the checkbox at all (uncheck check box -> textbox is empty -> check box immediately gets rechecked)

[DHowett]

Right. I think we should favor more expressive settings (a checkbox for "use parent folder" instead of the empty text field means use parent folder) with some user-facing affordances for making it convenient.

Here's an idea.

The text field only emits a Change event when the user navigates off of it. Can we move focus into the text field automatically when the user UNCHECKS the box, and then CHECK the box only when the user navigates off the text field with it empty?

We can rely on the profile viewmodel's PropertyChanged notification to implement that. We have to make sure we don't move focus back into the text field unless it was explicit user action on the check, but that should be doable.

We could also make the browse button override the checkbox (choosing a folder turns off the box and fills the field) using the same notification.

how's that sound/

[PankajBhojwani]

I like that idea, will wait on response from @cinnamon-msft before making a PR

[cinnamon-msft]

[DHowett]

Please use a new issue for this. It was "removed or fixed" up to 1.6 standard.