Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on tab context menu after a few mouse right-clicks #8944

Closed
TobiasSekan opened this issue Jan 29, 2021 · 5 comments
Closed

Crash on tab context menu after a few mouse right-clicks #8944

TobiasSekan opened this issue Jan 29, 2021 · 5 comments
Assignees
@DHowett
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Milestone
Terminal v1.6

Comments

@TobiasSekan
Copy link

TobiasSekan commented Jan 29, 2021 •
edited
Loading

Environment

PS C:\Users\Ich> [Environment]::OSVersion

Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.19042.0 Microsoft Windows NT 10.0.19042.0

Windows Terminal Preview
Version: 1.6.10272.0

Steps to reproduce

  1. Start terminal
  2. Mouse right-click on a tab
  3. A few mouse right-clicks on a different context menu entries

Expected behavior

Don't crash (silent)

Actual behavior

unlimited of this:
2021-01-29 13_58_02-Solution1 (Debugging) - Microsoft Visual Studio Preview

When you tell me how can I get a better debug about this crash, I want to given you a better error report
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 29, 2021
@zadjii-msft
Copy link
Member

Shit. This is the context menu crash from over in #8238. @DHowett we held the nested menu back from 1.5 because of this crash, but it looks like we didn't hold it back from 1.6 too. This is the second report since we shipped - I bet we're gonna see a few more of these too.

I'm gonna re-purpose this to make sure we push a hotfix to revert than ASAP.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. labels Jan 29, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 29, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.6 milestone Jan 29, 2021
@zadjii-msft zadjii-msft mentioned this issue Feb 1, 2021
Closed
DHowett added a commit that referenced this issue Feb 10, 2021
@DHowett
[1.5 ONLY] Remove the close submenu
c8dea3d 
There's a platform issue that causes it to crash.
Fixes #8944.
@DHowett DHowett mentioned this issue Feb 10, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Feb 10, 2021
DHowett added a commit that referenced this issue Feb 10, 2021
@DHowett
[1.5 ONLY] Remove the close submenu (#9102)
5fdd156 
There's a platform issue that causes it to crash.
Fixes #8944.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 10, 2021
@DHowett DHowett closed this as completed Feb 10, 2021
@DHowett
Copy link
Member

DHowett commented Feb 10, 2021

I'm only holding this back from 1.5 -- it's "stable" afterall.

@DHowett
Copy link
Member

DHowett commented Feb 10, 2021

Ugh, okay, I'll cherry-pick it to 1.6.

DHowett added a commit that referenced this issue Feb 10, 2021
@DHowett
[1.5 ONLY] Remove the close submenu (#9102)
e13d1a7 
There's a platform issue that causes it to crash.
Fixes #8944.

(cherry picked from commit 5fdd156)
@ghost
Copy link

ghost commented Feb 11, 2021

🎉This issue was addressed in #9102, which has now been successfully released as Windows Terminal v1.5.10411.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Feb 11, 2021

🎉This issue was addressed in #9102, which has now been successfully released as Windows Terminal Preview v1.6.10412.0.:tada:

Handy links:

DHowett added a commit that referenced this issue Feb 24, 2021
@DHowett
[RELEASE ONLY] Remove the close submenu (#9102)
c951a70 
There's a platform issue that causes it to crash.
Fixes #8944.

(cherry picked from commit 5fdd156)
DHowett added a commit that referenced this issue Apr 13, 2021
@DHowett
[RELEASE ONLY] Remove the close submenu (#9102)
6072be5 
There's a platform issue that causes it to crash.
Fixes #8944.

(cherry picked from commit 5fdd156)
(cherry picked from commit c951a70)
@miniksa miniksa removed the zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. label Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v1.6
Development

No branches or pull requests
4 participants
@DHowett @TobiasSekan @miniksa @zadjii-msft