Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUI: Add settings for initalPosition, centerOnLaunch #9075

Closed
Tracked by #13392
zadjii-msft opened this issue Feb 8, 2021 · 5 comments · Fixed by #13605
Closed
Tracked by #13392

SUI: Add settings for initalPosition, centerOnLaunch #9075

zadjii-msft opened this issue Feb 8, 2021 · 5 comments · Fixed by #13605
Assignees
@PankajBhojwani
Labels
Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
22H2

Comments

@zadjii-msft
Copy link
Member

Basically the title. initialPosition is a weird setting because there's an x and y component, and that has to become a string like x, y.

Center on launch is also weird, because it doesn't disable other settings, it just has weird interactions with launchMode, specifically any of the modes where the terminal is maximized.

See also: #6800, #9036
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Settings UI Anything specific to the SUI labels Feb 8, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.7 milestone Feb 8, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 8, 2021
This was referenced Feb 8, 2021
Merged
Open
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 12, 2021
@zadjii-msft zadjii-msft mentioned this issue Aug 16, 2021
Closed
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft mentioned this issue Mar 7, 2022
Open
@carlos-zamora carlos-zamora mentioned this issue Jun 27, 2022
Open
65 tasks
@DHowett DHowett mentioned this issue Jun 29, 2022
Open
47 tasks
@PankajBhojwani PankajBhojwani self-assigned this Jul 22, 2022
@PankajBhojwani PankajBhojwani mentioned this issue Jul 26, 2022
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 26, 2022
@ghost ghost closed this as completed in #13605 Oct 5, 2022
ghost pushed a commit that referenced this issue Oct 5, 2022
@PankajBhojwani
Implement InitialPosition and CenterOnLaunch in the SUI (#13605)
40bc3d7 
## Summary of the Pull Request
`InitialPosition` and `CenterOnLaunch` can now be edited in the SUI

## PR Checklist
* [x] Closes #9075 
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

## Detailed Description of the Pull Request / Additional comments
`InitialPosition` follows the same style as `LaunchSize`, with a number box for the x coordinate and a number box for the y coordinate. When there is no value for either of these coordinates, the respective number box is empty (and displays the text `Undefined`). 

## Validation Steps Performed
They work
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 5, 2022
@vefatica
Copy link

vefatica commented Jan 3, 2023

Has this been implemented? I can't find it in WindowsTerminalPreview: 1.16.2212.12003

@zadjii-msft
Copy link
Member Author

Nope. This was first merged in #13605, which should be released in 1.17.

@vefatica
Copy link

vefatica commented Jan 4, 2023

Thanks. I had looked (quickly) at #13605. Should I have been able to figure out when it would be released?

@zadjii-msft
Copy link
Member Author

I mean, the fact that it doesn't yet have a "This PR was released in {{version_number}}" post by the bot implies that it hasn't' yet been released, so it will be shipped in the next version. When exactly 1.17 is coming out is something we're still pinning down, but it'll be in 1.17 for sure.

@ghost
Copy link

ghost commented Jan 24, 2023

🎉This issue was addressed in #13605, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
22H2
Development

Successfully merging a pull request may close this issue.

Implement InitialPosition and CenterOnLaunch in the SUI microsoft/terminal
4 participants
@DHowett @zadjii-msft @PankajBhojwani @vefatica