-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please provide a new setting: verticalScrollBarWidth #9218
Comments
Just popping in to say that this would be appreciated very much! I don't like the current scrollbar behavior. Thanks! |
I need this as well, because it is too slim and this makes it difficult to click it with the mouse pointer. it's actually identically as slim as msedge's, perhaps I should also ask this to Edge team as well. |
Workaround: activating "Arero Lite Theme" gives you back the scroll bar. As used in this script: https://github.com/mhgschmidt/w10install/blob/master/scripts/modify-desktoptheme.cmd Works for me. Givin up and closing this ticket. |
@mhgschmidt please leave it open. I don't want to alter the theme. |
if you don't want to get notifications of this issue, you can unsubscribe from it. but there are others who don't want the theme workaround. and it's a workaround, not a solution to the issue you opened |
Reopened. |
If you'd like to contribute, we'd happily review the PR. I'm not sure there's an easy way to change the width of a XAML scrollbar, but if there is, this would be the place to start: terminal/src/cascadia/TerminalControl/TermControl.xaml Lines 92 to 105 in e5293b7
|
lmao it works but looks insane: @StephenLPeters (sorry you're my go to "winui on GH person" now) Any ideas if there's an easy way to set the thickness of the thumb too? This obviously looks insane. At least the whole track works for hit testing, though, the up/down buttons don't. |
Note to self: |
@zadjii-msft this is the resource that drives this value: https://github.com/microsoft/microsoft-ui-xaml/blob/e4c5d3443caa0242be0953010dd5ab3ddb4c2925/dev/CommonStyles/ScrollBar_themeresources.xaml#L785 unfortunately it is a StaticResource defined in a Non-ThemeDictionary in Winui2 which, because of some... quirks... in the resource lookup system means that you will not be able to override this propety from Terminal. Therefore I think the only option you have is to retemplate the control. We could/should fix this in winui2 and make it a ThemeResource which would allow you to override it in the visual tree. |
@StephenLPeters thanks for the follow up. Seems to me like the best course of action would be:
Sound like a plan? |
Yes, although we should confirm that this resource is the only one that you need access to in order to fulfill your design. Its possible that you'd also need to change the roundedness of the corners or the margin from the edge of the well, or something like that. Maybe we can pull the nuget package from our PR pipeline and test that terminal is able to make the changes you need. I'll make the PR now. |
Team discussion:
Oh look at that. He just fixed it like that, because he's the best. microsoft/microsoft-ui-xaml#6686. Thanks! That might change our previously discussed plans. More discussion to follow tomorrow, I'm sure. |
I suspect there is more that is needed to make this look correct.. for instance the chevrons are also miss sized so we'll need to figure out the set of resources that are needed. |
I'm sorry, I need to downvote this. I completely agree that the scrollbars are too thin, but we really should not be configuring scrollbars separately for every app. Scrollbars have gotten too thin everywhere (Feedback hub, Window News, Xbox apps, every single Electron app, the list goes on.) This really needs to be pushed up to some Microsoft UI team so we can control this globally at the OS level for all apps. |
until you find the right place to file the issue with microsoft, downvoting this helps no one. |
Actually, you know what? I'm inclined to agree with @jvincent-siplay. No other application in common use today offers this kind of customization--if it would, does it offer a switch for making the buttons smaller or larger? Or making the status bar taller or shorter? The caption controls smaller, redder, or more translucent?--and so I don't think we should either. I would say that downvoting this issue has helped us, as I think it's going to clear this thing off our backlog that shouldn't be on it. The Terminal team is able to funnel these feature requests to the right people, but we have no special ability to make sure they get acted on. |
the problem is microsoft terminal is a rebel citizen in windows 10 see how other native microsoft apps have their scrollbars in windows 10: device manager, command prompt, explorer, task manager, edge, uwp settings app |
what all these scrollbars have in common? they're all usable. they're usable interactive ui elements, not just page progress indicators like terminal does. yes, you can click terminal scroll bar, but at the high cost of wasted time due to terrible low mouse grab precision which ends up giving up using it. if you call customization the ability to be usable... then I am left with no other argument. |
FWIW, that was added in #14047, and is shipping in 1.17. We also changed the width of the Terminal's scrollbar to align with the rest of the OS's scrollbar's in #12608, back in 1.14. We're a WinUI-style scrollbar, with a ComCtl-style width now.
🤔 In general, the Terminal repo isn't the right place for feedback on the design of the WinUI scroll bars. A better place for your feedback would be: microsoft/microsoft-ui-xaml#7422 |
I also use scroll bar to track where am I in the jungle of huge command line output.
Thanks! Eagerly waiting for the release then. |
With Windows Terminal v1.12.1073, the scrollbar looks like this: however starting with the next version, Windows Terminal v1.12.1098, the scrollbar is narrow: and in future versions even rounded at the corners. I find these changes distracting. Also, they are different from my browser Mozilla Firefox: My editor Vim: and even Windows Explorer: this is quite annoying, I wish Microsoft would just focus on making the terminal itself better, and not spend time on these "bikeshed" issues, especially in regards to changes that are difficult or impossible for users to revert. in my case I am now forced to use the old version forever. |
Please consider visually impaired users too - the current indicator is also too small |
Please provide an option in the config.json to:
Why should users use this?
The new behaviour of the vertical scrollbar in windows terminal provides no advantage. It's confusing the users.
Many users want to use windows terminal as replacement for the dos box and this new behaviour drives them crazy.
Example:
"defaults":
{
"scrollBarState" : "visible",
"verticalScrollBarWidth" : 32
}
... and this will set the vertical scrollbar to a fixed width
The text was updated successfully, but these errors were encountered: