-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical scroll bar too narrow #12395
Comments
This is probably covered by #9218. |
I haven't been following the UI development closely, but I assume at least some of these changes are to match the style guidelines for Windows 11. Those button icons do look more likely to be a bug though. |
And colors and fonts have changed (tabs and tab area background). And navigation in the settings UI has changed rather drastically ("General", "Appearance", and "Advanced" no longer have equal status). None of it gets thumbs-up from me. |
I'm not a fan of all the new UI changes, but that's always the way of things - you can't please everyone. And maybe one day we'll get the XAML theming functionality (#3327) and I'll finally be able to reskin my terminal in the style of Windows 3.1. |
I wonder whom they're trying to please. Maybe someone who likes the changes will chime in. |
I agree. I personally do not consider the new scrollbars as optimal for mouse usage. But I can see how they make a lot of sense in the context of most WinUI applications, where overlay scrollbars are beneficial. However as much as I'd personally like to create an alternative scrollbar appearance, Windows Terminal is still an important test ground for WinUI and while it's not impossible, it's realistically unlikely that we'll adopt something that isn't natively implementable with WinUI. As such foundational UI feedback like this should be directed to https://github.com/microsoft/microsoft-ui-xaml I believe. |
If that's so, I'm confident that those developers are paying close attention to feedback here. And if feedback should be directed to them that would seem to be the job of the WindowsTerminal team (not mine). |
At this point they can simply remove it, since it's 99% impossible to grab it with the mouse with sufficient reaction time to be useful. https://i.imgur.com/6Gh2QIa.png What a mockery, microsoft! |
I'll have to agree here. The new 1.13 update brings in a lot of (breaking) changes for Windows 10 users (which according to Microsoft is still supported till 2025). I never had UI problems with Preview updates before, but it is very un-Microsoft-y to neglect old-gen (here, Windows 10) users with usability stuff like this.
Please correct me if I'm wrong, but isn't the whole point of having a scroll bar, to facilitate mouse usage? I presume it's going to be problematic even for Windows 11 users (if the width is as narrow there as Windows 10). |
Alright, thanks for the feedback everyone. I'm gonna move this discussion upstream to microsoft/microsoft-ui-xaml#6684. We'll see if the fix for #9218 is trivial, that might be the easiest, fastest fix here. |
BODGY: Controlsv2 changed the size of the scrollbars from 16dips to 12dips. This is harder for folks to hit with the mouse, and isn't consistent with the rest of the scrollbars on the platform (as much as they can be). To work around this, we have to entirely copy the template for the ScrollBar into our XAML file. We're then also re-defining ScrollBarSize here to 16, so that the new template will pick up on the new value. This is kinda a pain, and we have to be careful to be sure to ingest an updated version of the template any time we update MUX. The latest Controlsv2 version of the template can be found at: https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218 We're also planning on making this adjustable in the future (GH#9218), where we might need this anyways. ##### after, before: ![image](https://user-images.githubusercontent.com/18356694/156254464-1a9080f6-51ce-4619-b002-2a3c607cdf5f.png) ##### after overlayed on top of before ![image](https://user-images.githubusercontent.com/18356694/156254546-fccc3cee-12a3-4e1a-8fd7-7470f1ec93ad.png) ##### comparison ![image](https://user-images.githubusercontent.com/18356694/156257934-ec4ac840-c8ca-4fca-a848-08a32b1c55c3.png) * reported originally in #12395 * upstream: microsoft/microsoft-ui-xaml#6684 * closes an element of #12400
BODGY: Controlsv2 changed the size of the scrollbars from 16dips to 12dips. This is harder for folks to hit with the mouse, and isn't consistent with the rest of the scrollbars on the platform (as much as they can be). To work around this, we have to entirely copy the template for the ScrollBar into our XAML file. We're then also re-defining ScrollBarSize here to 16, so that the new template will pick up on the new value. This is kinda a pain, and we have to be careful to be sure to ingest an updated version of the template any time we update MUX. The latest Controlsv2 version of the template can be found at: https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218 We're also planning on making this adjustable in the future (GH#9218), where we might need this anyways. ##### after, before: ![image](https://user-images.githubusercontent.com/18356694/156254464-1a9080f6-51ce-4619-b002-2a3c607cdf5f.png) ##### after overlayed on top of before ![image](https://user-images.githubusercontent.com/18356694/156254546-fccc3cee-12a3-4e1a-8fd7-7470f1ec93ad.png) ##### comparison ![image](https://user-images.githubusercontent.com/18356694/156257934-ec4ac840-c8ca-4fca-a848-08a32b1c55c3.png) * reported originally in #12395 * upstream: microsoft/microsoft-ui-xaml#6684 * closes an element of #12400 (cherry picked from commit da2cf8c)
BODGY: Controlsv2 changed the size of the scrollbars from 16dips to 12dips. This is harder for folks to hit with the mouse, and isn't consistent with the rest of the scrollbars on the platform (as much as they can be). To work around this, we have to entirely copy the template for the ScrollBar into our XAML file. We're then also re-defining ScrollBarSize here to 16, so that the new template will pick up on the new value. This is kinda a pain, and we have to be careful to be sure to ingest an updated version of the template any time we update MUX. The latest Controlsv2 version of the template can be found at: https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218 We're also planning on making this adjustable in the future (GH#9218), where we might need this anyways. ##### after, before: ![image](https://user-images.githubusercontent.com/18356694/156254464-1a9080f6-51ce-4619-b002-2a3c607cdf5f.png) ##### after overlayed on top of before ![image](https://user-images.githubusercontent.com/18356694/156254546-fccc3cee-12a3-4e1a-8fd7-7470f1ec93ad.png) ##### comparison ![image](https://user-images.githubusercontent.com/18356694/156257934-ec4ac840-c8ca-4fca-a848-08a32b1c55c3.png) * reported originally in #12395 * upstream: microsoft/microsoft-ui-xaml#6684 * closes an element of #12400
The vertical scroll bar was sufficiently narrow so as to make it difficult to use. And, IIRC, someone recently asked about making it wider (I'll second that, a little late). In 1.13.10336.0 it's even narrower than it was previously. Things don't seem to be going in the right direction.
The text was updated successfully, but these errors were encountered: