Skip to content

Commit

Permalink
Make the Scrollbar 16dips again (#12608)
Browse files Browse the repository at this point in the history
BODGY: Controlsv2 changed the size of the scrollbars from 16dips to
12dips. This is harder for folks to hit with the mouse, and isn't
consistent with the rest of the scrollbars on the platform (as much
as they can be).

To work around this, we have to entirely copy the template for the
ScrollBar into our XAML file. We're then also re-defining
ScrollBarSize here to 16, so that the new template will pick up on
the new value.

This is kinda a pain, and we have to be careful to be sure to ingest
an updated version of the template any time we update MUX. The
latest Controlsv2 version of the template can be found at:
https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218

We're also planning on making this adjustable in the future
(GH#9218), where we might need this anyways.

##### after, before:
![image](https://user-images.githubusercontent.com/18356694/156254464-1a9080f6-51ce-4619-b002-2a3c607cdf5f.png)

##### after overlayed on top of before
![image](https://user-images.githubusercontent.com/18356694/156254546-fccc3cee-12a3-4e1a-8fd7-7470f1ec93ad.png)

##### comparison
![image](https://user-images.githubusercontent.com/18356694/156257934-ec4ac840-c8ca-4fca-a848-08a32b1c55c3.png)

* reported originally in #12395
* upstream: microsoft/microsoft-ui-xaml#6684
* closes an element of #12400

(cherry picked from commit da2cf8c)
  • Loading branch information
zadjii-msft authored and DHowett committed Mar 10, 2022
1 parent 763f9b0 commit 5a5c17d
Show file tree
Hide file tree
Showing 2 changed files with 1,145 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/actions/spelling/allow/allow.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ downside
downsides
dze
dzhe
EDDB
EDDC
Enum'd
Fitt
formattings
Expand Down Expand Up @@ -74,6 +76,8 @@ runtimes
shcha
slnt
Sos
timeline
timelines
timestamped
TLDR
tokenizes
Expand Down
Loading

0 comments on commit 5a5c17d

Please sign in to comment.