Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light mode in settings UI only #9231

Closed
Lombra opened this issue Feb 20, 2021 · 5 comments · Fixed by #16479
Closed

Light mode in settings UI only #9231

Lombra opened this issue Feb 20, 2021 · 5 comments · Fixed by #16479
Labels
Area-SettingsUI Anything specific to the SUI Area-Theming Anything related to the theming of elements of the window Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.

Comments

@Lombra
Copy link

Lombra commented Feb 20, 2021

Description of the new feature/enhancement

Since my shells are all dark, it makes sense to use dark mode to get the dark title bar, however Windows' idea of dark mode design means the new settings UI is an eyesore. I would like to have the settings UI use light mode.

@Lombra Lombra added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Feb 20, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 20, 2021
@zadjii-msft
Copy link
Member

Okay, sure. I'll slap this into the megathread for "theming", #3327. Something like settingsUi.requestedTheme: light|dark|system. Why not.

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Feb 22, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Feb 22, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 22, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 23, 2021
@zadjii-msft zadjii-msft added Area-SettingsUI Anything specific to the SUI Area-Theming Anything related to the theming of elements of the window and removed Area-UserInterface Issues pertaining to the user interface of the Console or Terminal labels Aug 4, 2021
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Sep 9, 2022
@zadjii-msft zadjii-msft moved this to Should be written in Terminal Walkthroughs Feb 6, 2023
@zadjii-msft
Copy link
Member

zadjii-msft commented Feb 6, 2023

Note

Walkthrough

  • Start by adding a new Theme object for the settings UI:
    • SettingsTheme in Theme.idl, quite similar to WindowTheme in the same file
    • Add a single ElementTheme RequestedTheme to that runtimeclass.
    • In MTSMSettings.h, define a new MTSM_THEME_SETTINGS_SETTINGS, again taking cues from the tab row version. The key for this one should just be "settings"
    • Add a THEME_OBJECT(SettingsTheme, MTSM_THEME_SETTINGS_SETTINGS); to Theme.h
    • Add the sui theme to the other places theme objects appear in Theme.cpp as well.
  • Actually use this new setting
    • MainPage::_UpdateBackgroundForMica is probably the right place for this, as it's already trying to set the RequestedTheme for the settings page.
    • Instead, use the settings.requestedTheme, if it is set.

@zadjii-msft zadjii-msft moved this from Should be written to Walkthrough in issue in Terminal Walkthroughs Feb 6, 2023
@bundgaard
Copy link
Contributor

bundgaard commented Oct 3, 2023

Hello,

I am looking into this at the moment, but I hit a snag, where I am unsure if I should proceed or you might have some pointers to a better solution.

Just some background on my machine, I am running Windows 11 Pro Version 10.0.22621 Build 22621.
To make it work on my machine I had to remove the isMicaAvailable check in MainPage.cpp function ::_UpdateBackgroundForMica(). I tested to print out the value from the DwmGetWindowAttribute() and it always returns DWMSBT_NONE, therefore I removed the check for Mica.

I assume the isMicaAvailable check is there for a reason for backward compatibility?

Also I will remove the DebugOutputStringW() and the switch case, if we proceed with this.

@zadjii-msft
Copy link
Member

I assume the isMicaAvailable check is there for a reason for backward compatibility?

That was introduced in #14675. That might have more context

(it's almost 5pm here so I can take a look deeper in the morning)

@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Oct 4, 2023
@Stromlight
Copy link

Description of the new feature/enhancement

Since my shells are all dark, it makes sense to use dark mode to get the dark title bar, however Windows' idea of dark mode design means the new settings UI is an eyesore. I would like to have the settings UI use light mode.

I don't think dark and white mode had any good feature so far I use lots of app but I don't find it's better use then brightness.instead of dark and white mode what about adding overview of app so user can get must out of it .

github-merge-queue bot pushed a commit that referenced this issue Jul 1, 2024
Adds support for a new `settings` object in the theme settings. This
includes a single property, `theme`. This allows users to set a
different theme from the app's requested theme, if they so choose.

Closes #9231

---------

Co-authored-by: Mike Griese <migrie@microsoft.com>
@github-project-automation github-project-automation bot moved this from Walkthrough in issue to Done in Terminal Walkthroughs Jul 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-SettingsUI Anything specific to the SUI Area-Theming Anything related to the theming of elements of the window Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
Status: Done
5 participants