-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings UI navigation view has a transparent background when opened as an overlay #9337
Comments
Holy gosh that looks bad. Unfortunately, I don't have a local repro for this 😢. It looks like the blur from the acrylic just is not getting applied. Does acrylic work anywhere else in the app? I'm trying to think of somewhere else that would have in-app acrylic to test. I'm not sure there's any in the Terminal. Maybe try the XAML Controls Gallery app? That should have a sample NavigationView to compare with |
Ah OK. I have "Transparency Effects" turned off in the in the System settings. If I turn that on (and change my power mode to "Best Performance", which is needed for acrylic to work), then the navigation panel displays correctly. If I turn "Transparency Effects" off, it immediately goes transparent again. In other apps, the acrylic area just becomes completely opaque. |
Just checked the XAML Controls Gallery (version 1.2.17.0 in case that makes any difference), and the NavigationView example has an acrylic overlay which works correctly, i.e. it's acrylic when "Transparency Effects" are enabled, and opaque when disabled. |
Sounds like the fallback brush of acrylic is set to transparent. In practice, it should be set to non transparent. |
Huh, I didn't think that you could set a fallback brush to Transparent. I bet that's exactly happening. It's extremely trivial to repro this by disabling "transparency effects" in the Settings app, so yea I bet we're doing something wrong here. |
Has someone failed to add a fallback colour for the Acrylic brush, or is it maybe not being used like it should be? |
I remember that no fallback would cause transparent be used. |
It will be a different color than the background, so it will look less weird when it's unfocused. It also fixes the bug where the navigation menu is transparent when acrylic is disabled systemwide. Fixes #9337
It will be a different color than the background, so it will look less weird when it's unfocused. It also fixes the bug where the navigation menu is transparent when acrylic is disabled systemwide. Fixes #9337
🎉This issue was addressed in #9752, which has now been successfully released as Handy links: |
🎉This issue was addressed in #9752, which has now been successfully released as Handy links: |
Environment
Windows build number: Version 10.0.18363.1316
Windows Terminal version (if applicable): 1.7.572.0 (preview)
Steps to reproduce
Expected behavior
The navigation panel should have an opaque background, covering the content that it is overlaying.
Actual behavior
The navigation panel seems to have a transparent background, so you can still see the content below it, making the menu items unreadable.
The text was updated successfully, but these errors were encountered: