-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for focusPane
action, focus-pane
subcommand
#10142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving contingent on the resw file thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I couldn't find any real issues. ¯\_(ツ)_/¯
// Make sure to use _FocusFirstChild here - that'll properly update the | ||
// focus if we're in startup. | ||
_FocusFirstChild(); | ||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this returns, you don't need the else
.
@msftbot merge this in 10 minutes |
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
🎉 Handy links: |
Summary of the Pull Request
Adds support for the
focusPane
action, and thefocus-pane
subcommand. These allow the user to focus a pane by it's ID.focusPane
accepts anid
, identifying the id of the pane to focus.focus-pane
,fp
requires the parameter--target,-t
to ID the pane it's going to focus.PR Checklist
focus-pane
subcommand #5464Detailed Description of the Pull Request / Additional comments
The ID isn't totally useful right now, since users can't see them. But they're there, and used in-order. This is just slightly more ergonomic for complicated commandlines than
mf up; mf left
Validation Steps Performed
Tested in command palette
Tested a variety of commandlines.
wtd -w 0 mf down ; sp
andwtd -w 0 fp -t 1 ; sp
gave me special difficulty.