Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Pane to Tab (GH7075) #10780

Merged
24 commits merged into from
Aug 12, 2021
Merged

Commits on Jul 20, 2021

  1. first very-much-not-working pass. Need to figure out how to manage al…

    …l of the vestigial event handlers when we switch which tab owns a pane.
    Rosefield committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    0fb4b38 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2021

  1. GH7075 Move Pane to Tab

    - First (not-really-functional) pass at adding move pane to tab functionality. Moving a pane to a new tab seems to work. Everything else is questionable (exceptions abound).
    - Set up {Attach,Detach}Pane methods to add or remove a pane from a pane. Detach is slightly different than Close in that we want to persist the tree structure and terminal controls.
    - Add `Detached` event on a pane that can be subscribed to to remove other event handlers if desired. Still need to figure out how to handle removing unwanted event handlers on the actual terminal control.
    - Added simple WalkTree abstraction for one-off recursion use cases that calls a provided function on each pane in order (and optionally terminates early).
    Rosefield committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    4adfdee View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2021

  1. Remove control event handlers when pane is detached. Make sure event …

    …handlers are removed when a tab gets closed as well. Try to keep active state updated when detaching
    Rosefield committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    e33b7aa View commit details
    Browse the repository at this point in the history
  2. Appease the spelling bot

    Rosefield committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    64346fb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d66d02e View commit details
    Browse the repository at this point in the history
  4. Fix typos

    Rosefield committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    b8e95e3 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. Anticipate some code review refactoring. Make sure that we clean up e…

    …xtra closed handlers if we are moving the root element from a tab. Make sure that we preserve the ids when we attach a child from another tab.
    Rosefield committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    3bb24b2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4077160 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2021

  1. Configuration menu
    Copy the full SHA
    a7d7aec View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/main' into feature/gh7075-move-p…

    …ane-to-tab
    
     Conflicts:
    	doc/cascadia/profiles.schema.json
        src/cascadia/TerminalApp/Pane.h
    	src/cascadia/TerminalApp/TabManagement.cpp
    Rosefield committed Aug 1, 2021
    Configuration menu
    Copy the full SHA
    e7a9d21 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. Merge remote-tracking branch 'origin/main' into feature/gh7075-move-p…

    …ane-to-tab
    
     Conflicts:
    	src/cascadia/TerminalApp/TerminalTab.cpp
    	src/cascadia/TerminalSettingsModel/AllShortcutActions.h
    Rosefield committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    eea166c View commit details
    Browse the repository at this point in the history
  2. Fix bug where border is lost when child is closed. Make it explicit w…

    …hat kind of split is being made when a pane is attached (so that in the future it doesnt have to always be an automatic split)
    Rosefield committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    abe6a2b View commit details
    Browse the repository at this point in the history
  3. spelling

    Rosefield committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    530f658 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. Configuration menu
    Copy the full SHA
    d1ed59c View commit details
    Browse the repository at this point in the history
  2. Make separate DetachRoot function so that logic can be used separatel…

    …y (e.g. make tab into pane). Make Pane::DetachPane take a pointer to a pane so that any pane can be detached instead of just ones with ids.
    Rosefield committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    23b1ccf View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. fix comment

    Rosefield committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    ae1a84a View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Configuration menu
    Copy the full SHA
    ef5089f View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2021

  1. Merge remote-tracking branch 'origin/main' into feature/gh7075-move-p…

    …ane-to-tab
    
     Conflicts:
    	src/cascadia/TerminalApp/TerminalPage.cpp
    	src/cascadia/TerminalApp/TerminalPage.h
    Rosefield committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    2188f6b View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Configuration menu
    Copy the full SHA
    c6c9cc1 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/main' into feature/gh7075-move-p…

    …ane-to-tab
    
     Conflicts:
    	src/cascadia/TerminalApp/Pane.h
    Rosefield committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    012747a View commit details
    Browse the repository at this point in the history
  3. formatting

    Rosefield committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    4d9e571 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e91c69c View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Configuration menu
    Copy the full SHA
    61a3cae View commit details
    Browse the repository at this point in the history
  2. Fix crash introduced with last merge; dont try to ask the root pane f…

    …or state after it has been set to nullptr when closing the tab
    Rosefield committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    1e048e2 View commit details
    Browse the repository at this point in the history