-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Pane to Tab (GH7075) #10780
Move Pane to Tab (GH7075) #10780
Commits on Jul 20, 2021
-
first very-much-not-working pass. Need to figure out how to manage al…
…l of the vestigial event handlers when we switch which tab owns a pane.
Configuration menu - View commit details
-
Copy full SHA for 0fb4b38 - Browse repository at this point
Copy the full SHA 0fb4b38View commit details
Commits on Jul 24, 2021
-
- First (not-really-functional) pass at adding move pane to tab functionality. Moving a pane to a new tab seems to work. Everything else is questionable (exceptions abound). - Set up {Attach,Detach}Pane methods to add or remove a pane from a pane. Detach is slightly different than Close in that we want to persist the tree structure and terminal controls. - Add `Detached` event on a pane that can be subscribed to to remove other event handlers if desired. Still need to figure out how to handle removing unwanted event handlers on the actual terminal control. - Added simple WalkTree abstraction for one-off recursion use cases that calls a provided function on each pane in order (and optionally terminates early).
Configuration menu - View commit details
-
Copy full SHA for 4adfdee - Browse repository at this point
Copy the full SHA 4adfdeeView commit details
Commits on Jul 25, 2021
-
Remove control event handlers when pane is detached. Make sure event …
…handlers are removed when a tab gets closed as well. Try to keep active state updated when detaching
Configuration menu - View commit details
-
Copy full SHA for e33b7aa - Browse repository at this point
Copy the full SHA e33b7aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64346fb - Browse repository at this point
Copy the full SHA 64346fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d66d02e - Browse repository at this point
Copy the full SHA d66d02eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8e95e3 - Browse repository at this point
Copy the full SHA b8e95e3View commit details
Commits on Jul 29, 2021
-
Anticipate some code review refactoring. Make sure that we clean up e…
…xtra closed handlers if we are moving the root element from a tab. Make sure that we preserve the ids when we attach a child from another tab.
Configuration menu - View commit details
-
Copy full SHA for 3bb24b2 - Browse repository at this point
Copy the full SHA 3bb24b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4077160 - Browse repository at this point
Copy the full SHA 4077160View commit details
Commits on Aug 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a7d7aec - Browse repository at this point
Copy the full SHA a7d7aecView commit details -
Merge remote-tracking branch 'origin/main' into feature/gh7075-move-p…
…ane-to-tab Conflicts: doc/cascadia/profiles.schema.json src/cascadia/TerminalApp/Pane.h src/cascadia/TerminalApp/TabManagement.cpp
Configuration menu - View commit details
-
Copy full SHA for e7a9d21 - Browse repository at this point
Copy the full SHA e7a9d21View commit details
Commits on Aug 2, 2021
-
Merge remote-tracking branch 'origin/main' into feature/gh7075-move-p…
…ane-to-tab Conflicts: src/cascadia/TerminalApp/TerminalTab.cpp src/cascadia/TerminalSettingsModel/AllShortcutActions.h
Configuration menu - View commit details
-
Copy full SHA for eea166c - Browse repository at this point
Copy the full SHA eea166cView commit details -
Fix bug where border is lost when child is closed. Make it explicit w…
…hat kind of split is being made when a pane is attached (so that in the future it doesnt have to always be an automatic split)
Configuration menu - View commit details
-
Copy full SHA for abe6a2b - Browse repository at this point
Copy the full SHA abe6a2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 530f658 - Browse repository at this point
Copy the full SHA 530f658View commit details
Commits on Aug 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d1ed59c - Browse repository at this point
Copy the full SHA d1ed59cView commit details -
Make separate DetachRoot function so that logic can be used separatel…
…y (e.g. make tab into pane). Make Pane::DetachPane take a pointer to a pane so that any pane can be detached instead of just ones with ids.
Configuration menu - View commit details
-
Copy full SHA for 23b1ccf - Browse repository at this point
Copy the full SHA 23b1ccfView commit details
Commits on Aug 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ae1a84a - Browse repository at this point
Copy the full SHA ae1a84aView commit details
Commits on Aug 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ef5089f - Browse repository at this point
Copy the full SHA ef5089fView commit details
Commits on Aug 7, 2021
-
Merge remote-tracking branch 'origin/main' into feature/gh7075-move-p…
…ane-to-tab Conflicts: src/cascadia/TerminalApp/TerminalPage.cpp src/cascadia/TerminalApp/TerminalPage.h
Configuration menu - View commit details
-
Copy full SHA for 2188f6b - Browse repository at this point
Copy the full SHA 2188f6bView commit details
Commits on Aug 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c6c9cc1 - Browse repository at this point
Copy the full SHA c6c9cc1View commit details -
Merge remote-tracking branch 'origin/main' into feature/gh7075-move-p…
…ane-to-tab Conflicts: src/cascadia/TerminalApp/Pane.h
Configuration menu - View commit details
-
Copy full SHA for 012747a - Browse repository at this point
Copy the full SHA 012747aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d9e571 - Browse repository at this point
Copy the full SHA 4d9e571View commit details -
Configuration menu - View commit details
-
Copy full SHA for e91c69c - Browse repository at this point
Copy the full SHA e91c69cView commit details
Commits on Aug 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 61a3cae - Browse repository at this point
Copy the full SHA 61a3caeView commit details -
Fix crash introduced with last merge; dont try to ask the root pane f…
…or state after it has been set to nullptr when closing the tab
Configuration menu - View commit details
-
Copy full SHA for 1e048e2 - Browse repository at this point
Copy the full SHA 1e048e2View commit details