Fix SSE2 variant of TextColor::GetColor #10867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
force-pushed
the
dev/lhecker/fix-color-sse2
branch
from
34f0a43
to
3211923
Compare
DHowett
approved these changes
Aug 4, 2021
|
I'm surprised that no test case catches this?... |
34 tasks
zadjii-msft
approved these changes
Aug 4, 2021
miniksa
approved these changes
Aug 4, 2021
miniksa
added
the
AutoMerge
|
Hello @miniksa! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
|
Chester is correct- a test should have caught this. :/ |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortly before adding the SSE2 variant I "improved" it by using
_mm_packs_epi32, but failed to test it again afterwards.PR Checklist
Validation Steps Performed
printf "\e[mNORMAL \e[1mBOLD\n"results in correct bold white glyphs ✔️