-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fragments that update other profiles #11343
Conversation
Use white-space suppression to review 👌: https://github.com/microsoft/terminal/pull/11343/files?diff=split&w=1 |
@msftbot make sure @PankajBhojwani signs off on this |
Hello @zadjii-msft! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
@msftbot merge this in 2 minutes |
Hello @lhecker! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
SettingsLoader::_parse
used to skip profiles which didn't have either a "guid"or "name" field, due to #9962. This is however wrong for fragment loading, as
fragments can alternatively use an "updates" field instead of guid/name.
SettingsLoader::_parse
was updated to allow profiles with this alternativefield during fragment loading.
PR Checklist
Validation Steps Performed
%LOCALAPPDATA%\Microsoft\Windows Terminal\Fragments\test\test.json
: