Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable changing the bell sound #11511

Merged
16 commits merged into from
Jan 6, 2022
Merged

Enable changing the bell sound #11511

16 commits merged into from
Jan 6, 2022

Commits on Oct 14, 2021

  1. it honks

    zadjii-msft committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    be11388 View commit details
    Browse the repository at this point in the history
  2. many honks

    zadjii-msft committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    8fbd32d View commit details
    Browse the repository at this point in the history
  3. oh yea, it was that easy

    zadjii-msft committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    4c4fde9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cc9487e View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. Configuration menu
    Copy the full SHA
    0bb42ef View commit details
    Browse the repository at this point in the history
  2. it's a singleton now

    zadjii-msft committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    2c895b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f4ed0e View commit details
    Browse the repository at this point in the history
  4. thanks for nothing VS

    zadjii-msft committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    684956d View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Configuration menu
    Copy the full SHA
    2eda14c View commit details
    Browse the repository at this point in the history
  2. Experiment with removing the static MediaPlayer

      Somehow, this also causes an exception on teardown north of
      `Windows.Media.MediaControl.dll!AudioStateMonitorImpl::remove_SoundLevelChanged()`,
      which is in OS code somewhere. Not sure there's anything we can actually do
      about this. There are piles of bugs on that function in the OS repo.
    
      I think we're going to have to just end up avoiding this entirely.
    zadjii-msft committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    fb1ed58 View commit details
    Browse the repository at this point in the history
  3. Revert "Experiment with removing the static MediaPlayer"

    This reverts commit fb1ed58.
    zadjii-msft committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    0234404 View commit details
    Browse the repository at this point in the history
  4. it's BODGY time

    zadjii-msft committed Nov 16, 2021
    1 Configuration menu
    Copy the full SHA
    9393753 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Configuration menu
    Copy the full SHA
    28bb76e View commit details
    Browse the repository at this point in the history
  2. spel

    zadjii-msft committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    148f382 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. s/fo /of /

    zadjii-msft committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    796ce9f View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Apply suggestions from code review

    Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
    zadjii-msft and carlos-zamora authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    9f9cd41 View commit details
    Browse the repository at this point in the history