-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the ControlCore
layer to own a copy of its settings
#11619
Commits on Sep 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 43ec102 - Browse repository at this point
Copy the full SHA 43ec102View commit details -
Configuration menu - View commit details
-
Copy full SHA for dad065e - Browse repository at this point
Copy the full SHA dad065eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 981d8cc - Browse repository at this point
Copy the full SHA 981d8ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6989ec - Browse repository at this point
Copy the full SHA d6989ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b18bb4 - Browse repository at this point
Copy the full SHA 4b18bb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fc2f10 - Browse repository at this point
Copy the full SHA 7fc2f10View commit details
Commits on Sep 28, 2021
-
This says there's only one build error in Terminal.Control.Lib but th…
…at can't be right
Configuration menu - View commit details
-
Copy full SHA for c7536ed - Browse repository at this point
Copy the full SHA c7536edView commit details -
This works better than it has any business doing. Plemty of bugs, but…
… a good enough start
Configuration menu - View commit details
-
Copy full SHA for c26dd6b - Browse repository at this point
Copy the full SHA c26dd6bView commit details
Commits on Sep 30, 2021
-
I think I needed this to get it to build. Or I started breaknig somet…
…hing. Idk, I wrote this a few days ago, I just need this clone for testing so `git commit`
Configuration menu - View commit details
-
Copy full SHA for 4a1baf0 - Browse repository at this point
Copy the full SHA 4a1baf0View commit details
Commits on Oct 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for fbba74e - Browse repository at this point
Copy the full SHA fbba74eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1413d01 - Browse repository at this point
Copy the full SHA 1413d01View commit details
Commits on Oct 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 31e7998 - Browse repository at this point
Copy the full SHA 31e7998View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f7e883 - Browse repository at this point
Copy the full SHA 4f7e883View commit details
Commits on Oct 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a9de82e - Browse repository at this point
Copy the full SHA a9de82eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70b9f8c - Browse repository at this point
Copy the full SHA 70b9f8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0371194 - Browse repository at this point
Copy the full SHA 0371194View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4912b65 - Browse repository at this point
Copy the full SHA 4912b65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 888e157 - Browse repository at this point
Copy the full SHA 888e157View commit details
Commits on Oct 21, 2021
-
This is how I wanted to solve the color scheme setting, previewing, b…
…ut UpdateAppearance ends up getting called immediately after so it blows it away. Dustin had a crazy idea...
Configuration menu - View commit details
-
Copy full SHA for 17829f4 - Browse repository at this point
Copy the full SHA 17829f4View commit details -
you've seen WINRT_PROPERTY now get ready for RUNTIME_PROPERTY
and as soon ad I typed that out I realized that WINRT_PROPERTY already has setters and setting an optional override gets me nothing sure I could stealth the new value in underneath the runtime value, so reloading the settings doesn't reset font size, colors, etc I could but it sure does feel like overkill for "refactor but don't change anything"
Configuration menu - View commit details
-
Copy full SHA for 1aa2849 - Browse repository at this point
Copy the full SHA 1aa2849View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3a50cf - Browse repository at this point
Copy the full SHA e3a50cfView commit details
Commits on Oct 26, 2021
-
This almost works for previewing, but I fudged something up with the …
…backgrounds and now they're totally transparent
Configuration menu - View commit details
-
Copy full SHA for 9160966 - Browse repository at this point
Copy the full SHA 9160966View commit details -
Configuration menu - View commit details
-
Copy full SHA for 282c03c - Browse repository at this point
Copy the full SHA 282c03cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6babb4e - Browse repository at this point
Copy the full SHA 6babb4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94f4ef5 - Browse repository at this point
Copy the full SHA 94f4ef5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28cbad1 - Browse repository at this point
Copy the full SHA 28cbad1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 634b685 - Browse repository at this point
Copy the full SHA 634b685View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48ca704 - Browse repository at this point
Copy the full SHA 48ca704View commit details -
Some of these calls were duplicates. Some were redundant. Overall cle…
…anup of these guys.
Configuration menu - View commit details
-
Copy full SHA for 217742c - Browse repository at this point
Copy the full SHA 217742cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a700cd - Browse repository at this point
Copy the full SHA 4a700cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01cef2f - Browse repository at this point
Copy the full SHA 01cef2fView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 8c7ce77 - Browse repository at this point
Copy the full SHA 8c7ce77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c28851 - Browse repository at this point
Copy the full SHA 7c28851View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf9bf0e - Browse repository at this point
Copy the full SHA bf9bf0eView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for f087dd8 - Browse repository at this point
Copy the full SHA f087dd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f111c6d - Browse repository at this point
Copy the full SHA f111c6dView commit details
Commits on Oct 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 51486a4 - Browse repository at this point
Copy the full SHA 51486a4View commit details
Commits on Nov 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6da5d79 - Browse repository at this point
Copy the full SHA 6da5d79View commit details
Commits on Nov 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 83e7aea - Browse repository at this point
Copy the full SHA 83e7aeaView commit details
Commits on Nov 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d51c2cf - Browse repository at this point
Copy the full SHA d51c2cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9eeea4a - Browse repository at this point
Copy the full SHA 9eeea4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5173ea3 - Browse repository at this point
Copy the full SHA 5173ea3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 147101f - Browse repository at this point
Copy the full SHA 147101fView commit details -
> yes, but also, no. I tried doing that in 5173ea3, but alas, that doesn't work. There's a lot of places that assumes `IControlSettings requires IControlAppearance`. If you make `ControlSettings` only implement `IControlSettings` and `ICoreSettings`, and not the Appearances as well, then there are various places in UpdateSettings that will crash. (Those could likely be re-written as well, with some pain.) > > In almost all cases where we're using a `IControlSettings` as an Appearance, we're only interested in the `FocusedAppearance`'s value.
Configuration menu - View commit details
-
Copy full SHA for 5cd8096 - Browse repository at this point
Copy the full SHA 5cd8096View commit details -
5/6 transparency cases seem to work. Previewing with unfocused apprea…
…rance is broken again.
Configuration menu - View commit details
-
Copy full SHA for 713f72e - Browse repository at this point
Copy the full SHA 713f72eView commit details -
okay, so it's just vintage(100)+cleartype that doesn't work. Everythi…
…ng else gracefully falls back to grayscale
Configuration menu - View commit details
-
Copy full SHA for 59c193c - Browse repository at this point
Copy the full SHA 59c193cView commit details -
This works for opacity for all Terminal cases. Need to still fix conhost. ```json "persistedWindowLayouts" : [ { "initialPosition" : "149,43", "initialSize" : { "height" : 901.0, "width" : 1499.0 }, "tabLayout" : [ { "action" : "newTab", "commandline" : "c:\\windows\\system32\\cmd.exe /k colortool.exe -c", "profile" : "One Half Light + cleartype + acrylic", "startingDirectory" : null, "suppressApplicationTitle" : false, "tabTitle" : "One Half Light + cleartype + acrylic" }, { "action" : "splitPane", "commandline" : "c:\\windows\\system32\\cmd.exe /k colortool.exe -c", "profile" : "One Half Light + cleartype + vintage", "size" : 0.5, "split" : "right", "splitMode" : "manual", "startingDirectory" : null, "suppressApplicationTitle" : false, "tabTitle" : "One Half Light + cleartype + vintage" }, { "action" : "moveFocus", "direction" : "previousInOrder" }, { "action" : "splitPane", "commandline" : "c:\\windows\\system32\\cmd.exe /k colortool.exe -c", "profile" : "One Half Light + grayscale + acrylic", "size" : 0.70000004768371582, "split" : "down", "splitMode" : "manual", "startingDirectory" : null, "suppressApplicationTitle" : false, "tabTitle" : "One Half Light + grayscale + acrylic" }, { "action" : "splitPane", "commandline" : "c:\\windows\\system32\\cmd.exe /k colortool.exe -c", "profile" : "One Half Light + cleartype + acrylic(100)", "size" : 0.5, "split" : "down", "splitMode" : "manual", "startingDirectory" : null, "suppressApplicationTitle" : false, "tabTitle" : "One Half Light + cleartype + acrylic(100)" }, { "action" : "moveFocus", "direction" : "nextInOrder" }, { "action" : "splitPane", "commandline" : "c:\\windows\\system32\\cmd.exe /k colortool.exe -c", "profile" : "One Half Light + grayscale + vintage", "size" : 0.70000004768371582, "split" : "down", "splitMode" : "manual", "startingDirectory" : null, "suppressApplicationTitle" : false, "tabTitle" : "One Half Light + grayscale + vintage" }, { "action" : "splitPane", "commandline" : "c:\\windows\\system32\\cmd.exe /k colortool.exe -c", "profile" : "One Half Light + cleartype + vintage(100)", "size" : 0.5, "split" : "down", "splitMode" : "manual", "startingDirectory" : null, "suppressApplicationTitle" : false, "tabTitle" : "One Half Light + cleartype + vintage(100)" }, { "action" : "focusPane", "id" : 5 }, ] } ] ``` with the following profiles: ```json { "antialiasingMode": "cleartype", "colorScheme": "One Half Light", "commandline": "c:\\windows\\system32\\cmd.exe /k colortool.exe -c", "font": { "size": 8 }, "guid": "{e7f732da-f5c2-5f52-afd2-82518887a012}", "name": "One Half Light + cleartype + acrylic", "opacity": 50, "useAcrylic": true }, { "antialiasingMode": "cleartype", "colorScheme": "One Half Light", "commandline": "c:\\windows\\system32\\cmd.exe /k colortool.exe -c", "font": { "size": 8 }, "guid": "{e52bc30c-4fa8-5650-9c00-b619544efa5e}", "name": "One Half Light + cleartype + vintage", "opacity": 50, "useAcrylic": false }, { "antialiasingMode": "grayscale", "colorScheme": "One Half Light", "commandline": "c:\\windows\\system32\\cmd.exe /k colortool.exe -c", "font": { "size": 8 }, "guid": "{a870263b-0a3f-561f-82d2-bafc1163f1fc}", "name": "One Half Light + grayscale + acrylic", "opacity": 50, "useAcrylic": true }, { "antialiasingMode": "grayscale", "colorScheme": "One Half Light", "commandline": "c:\\windows\\system32\\cmd.exe /k colortool.exe -c", "font": { "size": 8 }, "guid": "{58a6ffb9-ead3-53ae-a696-c3eb27292578}", "name": "One Half Light + grayscale + vintage", "opacity": 50, "useAcrylic": false }, { "antialiasingMode": "cleartype", "colorScheme": "One Half Light", "commandline": "c:\\windows\\system32\\cmd.exe /k colortool.exe -c", "font": { "size": 8 }, "name": "One Half Light + cleartype + acrylic(100)", "opacity": 100, "useAcrylic": true }, { "antialiasingMode": "cleartype", "colorScheme": "One Half Light", "commandline": "c:\\windows\\system32\\cmd.exe /k colortool.exe -c", "font": { "size": 8 }, "name": "One Half Light + cleartype + vintage(100)", "opacity": 100, "useAcrylic": false }, ```
Configuration menu - View commit details
-
Copy full SHA for 6e8a2ad - Browse repository at this point
Copy the full SHA 6e8a2adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88f2e64 - Browse repository at this point
Copy the full SHA 88f2e64View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae833a7 - Browse repository at this point
Copy the full SHA ae833a7View commit details
Commits on Nov 11, 2021
-
* Dismissing a preview with an unfocused appearance is what's really broken here. That's never going to be able to go back to the original table, because the original table will be replaced with the unfocused appearance's table on the dismiss. - Going to fix that by using the focused appearance's table by default for the scheme when there's an unfocused appearance. * This is a little janky still, we flash the old schemes through on dismiss, which is probably wrong.
Configuration menu - View commit details
-
Copy full SHA for 2a18d7d - Browse repository at this point
Copy the full SHA 2a18d7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9e706c - Browse repository at this point
Copy the full SHA a9e706cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a7649c - Browse repository at this point
Copy the full SHA 1a7649cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5adb327 - Browse repository at this point
Copy the full SHA 5adb327View commit details -
Configuration menu - View commit details
-
Copy full SHA for a338ca1 - Browse repository at this point
Copy the full SHA a338ca1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8532dd6 - Browse repository at this point
Copy the full SHA 8532dd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bb8975 - Browse repository at this point
Copy the full SHA 7bb8975View commit details -
Configuration menu - View commit details
-
Copy full SHA for efdc090 - Browse repository at this point
Copy the full SHA efdc090View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8313987 - Browse repository at this point
Copy the full SHA 8313987View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1bfa33 - Browse repository at this point
Copy the full SHA a1bfa33View commit details
Commits on Nov 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b421ee6 - Browse repository at this point
Copy the full SHA b421ee6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d675fd8 - Browse repository at this point
Copy the full SHA d675fd8View commit details
Commits on Nov 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3acb374 - Browse repository at this point
Copy the full SHA 3acb374View commit details