Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scheme previewing on Appearances page of SUI #12095

Merged
1 commit merged into from
Jan 7, 2022
Merged

Fix scheme previewing on Appearances page of SUI #12095

1 commit merged into from
Jan 7, 2022

Conversation

zadjii-msft
Copy link
Member

This PR makes sure profile appearances in SUI set both focused and unfocused members of the control. I totally forgot about the fact that the control is unfocused in the SUI. Verified manually, I didn't think it deserved a gif.

@ghost ghost added Area-Settings UI Anything specific to the SUI Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. labels Jan 5, 2022
@DHowett DHowett added the Needs-Second It's a PR that needs another sign-off label Jan 7, 2022
@ghost ghost requested a review from miniksa January 7, 2022 18:21
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 7, 2022
@ghost
Copy link

ghost commented Jan 7, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit d7d89ef into main Jan 7, 2022
@ghost ghost deleted the dev/migrie/b/11893-scheme-preview-in-sui branch January 7, 2022 19:56
@ghost
Copy link

ghost commented Feb 3, 2022

🎉Windows Terminal Preview v1.13.10336.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Feb 3, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PankajBhojwani PankajBhojwani PankajBhojwani approved these changes

@DHowett DHowett DHowett approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The color scheme preview in the settings UI no longer works
3 participants
@zadjii-msft @DHowett @PankajBhojwani